streetcomplete / StreetComplete

Easy to use OpenStreetMap editor for Android
https://streetcomplete.app
GNU General Public License v3.0
3.9k stars 355 forks source link

Public transport quests for private platforms #4723

Closed Helium314 closed 1 year ago

Helium314 commented 1 year ago

I get the shelter / tactile paving / lit / ... quests for a platform that is inaccessible to normal people and not part of a regular stop: https://www.openstreetmap.org/way/245311267 Should SC respect the access=private here and not ask? Or is this some tagging issue, because public_transport could be interpreted as conflicting with access=private

matkoniecz commented 1 year ago

Is it some service platform in yards? In such case I would say that public_transport = platform is wrong, like putting it on freight train loading dock or train washing area would be.

Helium314 commented 1 year ago

Not sure, it's quite narrow and barely suitable for other uses than accessing the other end of the train. The tracks next to the platform are definitely not part of the normal subway connections (and actually do have service=yard tag)

matkoniecz commented 1 year ago

Changed in https://www.openstreetmap.org/changeset/130861549 - looks like one more victim of iD editor asking to blindly "upgrade" tags (which got a bit better since that time)

matkoniecz commented 1 year ago

Though maybe railway=platform still triggers the quest? I admit that I have not checked this.

And https://wiki.openstreetmap.org/wiki/Tag:railway=platform?uselang=en is not really clear are only public transport platforms supposed to be tagged with this - which ideally would be clarified first before changing SC.

I started https://wiki.openstreetmap.org/wiki/Talk:Tag:railway%3Dplatform#All_railway_platforms

Helium314 commented 1 year ago

Though maybe railway=platform still triggers the quest? I admit that I have not checked this.

It's only

          public_transport = platform
          or (highway = bus_stop and public_transport != stop_position)
HolgerJeromin commented 1 year ago

https://www.openstreetmap.org/way/219448424 on https://de.wikipedia.org/wiki/Bahnstrecke_Ludwigshafen_Hbf%E2%80%93Ludwigshafen_BASF

is a real platform where you are only able to leave the platform if you are an employee of BASF.

matkoniecz commented 1 year ago

Still, there is a good chance that it can be mappable without visiting it and this is so rare that just hiding it should be fine...

Though I guess that tested PR adding access filtering would be fine.