streetcomplete / StreetComplete

Easy to use OpenStreetMap editor for Android
https://streetcomplete.app
GNU General Public License v3.0
3.87k stars 353 forks source link

These quests should be enabled for Colombia #5078

Closed angoca closed 1 year ago

angoca commented 1 year ago

Use case Some quests have a restriction based on NoCountriesExcept to hide them in some countries. However, in Colombia, the following quests should be enabled because we have those kinds of features:

FloEdelmann commented 1 year ago

AddAcceptsCash

Are there many places that do not accept cash? Otherwise, (nearly) every answer would be "yes", so this quest would not pass the "no spam" guideline.

AddEntranceReference AddBusStopRef

Can you post a photo how those reference numbers look like?

AddCycleway

So many streets do have cycleways?

AddFireHydrantDiameter

Can you post a photo how the hydrant diameter sign looks like? Is nearly every hydrant signed by such a sign?

AddFuelSelfService

So there are many fuel stations that do not allow self service? Otherwise, this would be spam again.

AddTactilePavingBusStop AddTactilePavingCrosswalk

How common is tactile paving in Colombia?

angoca commented 1 year ago

Tactile paving: * 20230621_133426

* 20230621_133621

* 20230621_133603

* 20230617_161724

angoca commented 1 year ago

Cycleways: 20230621_133659 20230621_134244 20230621_133959

https://en.wikipedia.org/wiki/Bogot%C3%A1%27s_Bike_Paths_Network

matkoniecz commented 1 year ago

AddEntranceReference

Seems really rare: http://overpass-turbo.eu/s/1wtT http://overpass-turbo.eu/s/1wtU

mnalis commented 1 year ago

However, in Colombia, the following quests should be enabled because we have those kinds of features

As noted above, it is not a question whether those features exist, but how widespread they are. If there are (looking at a country as a whole, as SC doesn't have more precise sub-divisions) either too little (e.g. 1%) or too much (e.g. 99%) of that feature, then it would be problematic as it would "spam" the users (which might likely lead to them giving up on using the app completely). Ideally, the quest should have about 20-80% different answers across some country (just an example, not a hard limit).

So, because of that, one of the quest guidelines is:

  • :zzz: No spam: It must be possible to determine whether the quest should reasonably be asked. A quest which is to be answered in 99% of the time with the same answer is not a good quest, don't bore the users. I.e. asking for any road if it is a one-way road, is silly, because the vast majority of all roads will not be one-ways.

@angoca So the question is, can you give an estimate how much in % would the answers change for Colombia for each of the mentioned quests? (it would be great if you can give some links or overpass queries to back it up, but even just estimates would help).


P.S. StreetComplete guidelines are not perfect, of course. For example, some city in Colombia might very well qualify for quest, but if the rest of the country doesn't, it is not possible to express in StreetComplete - it can only be enabled or disabled for whole country. There is always an option of forking and changing it to suit your particular case, it's not that hard if there is a need for it. (at his point I actually usually recommend SCEE instead, but it seems not even there is overriding country blocks possible - would you think it would make sense @Helium314 ?)

Helium314 commented 1 year ago

it seems not even there is overriding country blocks possible

The main issue is that it would need to be allowed on a per-quest base. Some quests like hydrant diameter or cycleway need to be adapted to actually use the correct signing (hydrant signs, cycleway markings). For other quests like AddAcceptsCash this isn't necessary (though honestly I don't understand what is meant by "we have those kinds of features" in this context).

FloEdelmann commented 1 year ago

@angoca Could you please have a look at my questions in detail (and also see @mnalis's explanation) and try to answer them?

angoca commented 1 year ago

The initial objective of this issue was to ask for the inclusion of Colombia in the mentioned quests.

For example, for the hydrants, in this line: https://github.com/streetcomplete/StreetComplete/blob/7434f6bdf8ff2137a61bed94091c0c87e3cd09a3/app/src/main/java/de/westnordost/streetcomplete/quests/fire_hydrant_diameter/AddFireHydrantDiameter.kt#L31

Currently, it only appears in these countries:

override val enabledInCountries = NoCountriesExcept("DE", "BE", "GB", "PL", "IE", "FI", "NL")

And for the cycleway in this line https://github.com/streetcomplete/StreetComplete/blob/7434f6bdf8ff2137a61bed94091c0c87e3cd09a3/app/src/main/java/de/westnordost/streetcomplete/quests/cycleway/AddCycleway.kt#L50

override val enabledInCountries = NoCountriesExcept(
        // all of Northern and Western Europe, most of Central Europe, some of Southern Europe
        "NO", "SE", "FI", "IS", "DK",
        "GB", "IE", "NL", "BE", "FR", "LU",
        "DE", "PL", "CZ", "HU", "AT", "CH", "LI",
        "ES", "IT", "HR",
        // East Asia
        "JP", "KR", "TW",
        // some of China (East Coast)
        "CN-BJ", "CN-TJ", "CN-SD", "CN-JS", "CN-SH",
        "CN-ZJ", "CN-FJ", "CN-GD", "CN-CQ",
        // Australia etc
        "NZ", "AU",
        // some of Canada
        "CA-BC", "CA-QC", "CA-ON", "CA-NS", "CA-PE",
        // some of the US
        // West Coast, East Coast, Center, South
        "US-WA", "US-OR", "US-CA",
        "US-MA", "US-NJ", "US-NY", "US-DC", "US-CT", "US-FL",
        "US-MN", "US-MI", "US-IL", "US-WI", "US-IN",
        "US-AZ", "US-TX"
    )

And you asked me, "So many streets do have cycleway?". I already wrote that only Bogota has more than 500 Km of cycleways, and other cities have a lot of cycleways too. However, I don't know the total kilometers of cycleways, so we are mapping them.

Similar thing for hydrants, I don't know the total, but I know there are different types of diameters with the number on them (4 inches, 6 inches, 8 inches).

Regarding "AddAcceptsCash," many shops stop receiving cash only to receive cards, but I don't know the total number of shops accepting and not accepting cash.

"AddEntranceReference" could be used for houses with multiple doors with a different house number on each one, where a door connects directly to the second floor and another connection to another place in the house, for example. I know they exist, but I don't have details for the whole country.

The bus stops have a number on them, and "AddBusStopRef" could be used for that. I don't know how many bus stops do not have numbers across the country, but I know there are more than 6000 bus stops with a ref number only in Bogota.

In Colombia, self-service for fuel is not popular, so it is very important to identify the self-service stations with AddFuelSelfService.

In many mountains, the peak is marked with AddSummitCross, as we have Christian roots, so there are present everywhere, but I don't know how many peaks have a cross on them. And a quest like that at the peak won't be spam, as it could be the only available one in the area.

Also, some sidewalks and bus stops have tactile paving, but I don't know the proportion of sidewalks with and without tactile paving.

Initially, you asked if we have those features in Colombia, and I have shown they exist. But in the last comments, you wanted to give statistics about the proportion of the feature that exists or not to prevent spam which is almost impossible from a volunteer perspective.

mnalis commented 1 year ago

And you asked me, "So many streets do have cycleway?". I already wrote that only Bogota has more than 500 Km of cycleways, and other cities have a lot of cycleways too

I think it is misunderstood, it was never about absolute number of cycleways (or their total length). It is about ratio of "roads that has cycleways" to "roads that don't have cycleways". In other words: "what percentage of answers to that quest would have same answer?"

So the information "about 1 in 5 roads has cycleways" has great amount of wanted information (even if actual more precise number is "1 in 3" or "1 in 7" instead!), but "there is 500km or cycleways" or "there is 7k cycleways" would be useless, as it would not help answer the "spamminess" question.

And a quest like that at the peak won't be spam, as it could be the only available one in the area.

That reasoning I agree with; for that particular quest; it there are even just a few crosses in peaks in whole country (which should certainly be possible to find out!), it should be enabled.

Initially, you asked if we have those features in Colombia, and I have shown they exist. But in the last comments, you wanted to give statistics about the proportion of the feature that exists or not to prevent spam which is almost impossible from a volunteer perspective.

I understand that is is impossible to give exact percentage, but I don't think that anybody asked for that. But:

I agree that it does need some effort to research, but it pales in comparison by how much needless effort would be saved for all those Colombian mappers if spammy quest is not included.

So I think based on that it should be possible to classify each quest roughly in two categories:

(In case of doubt, you should err on the side of assuming that quest would be spammy.)


Note that this "spam" problem is only related to StreetComplete Quests, which are asked on every element.

Alternatives for quests which would be spammy data are:

FloEdelmann commented 1 year ago

Let's maybe split this issue into several issues and discuss/enable the quests individually. I think that would make the individual issues more actionable and avoid long back-and-forth questions and answers.

FloEdelmann commented 1 year ago

I extracted all suggestions to separate issues (see the links above), so I'll close this now.

@angoca Please note that many of those quests probably are worth enabling in Colombia given your examples. We just want to make sure that the quests are not enabled if they are hard to answer or spammy, and thus lead to bad or useless answers or many opened notes. We don't do this to scare you away!