streetcomplete / StreetComplete

Easy to use OpenStreetMap editor for Android
https://streetcomplete.app
GNU General Public License v3.0
3.92k stars 358 forks source link

Add Quest for tower:construction (affects: man_made=mast; man_made=tower; man_made=communications_tower) #5251

Closed gdprdatasubect closed 3 months ago

gdprdatasubect commented 1 year ago

General

Affected tag(s) to be modified/added: Masts, Towers, Big towers Question asked: What kind of tower/mast is this?

Checklist

Checklist for quest suggestions (see guidelines):

Ideas for implementation

Element selection: Select all man_made=mast, man_made=tower and man_made=communications_tower where tower:construction is not set

Proposed UI: Image-Based selection, similar to road-surfaces etc.

mnalis commented 1 year ago

Um, are you sure What kind of tower/mast is this? would be the ideal question for setting tower:construction=*? To me answers to that question would be things like communication tower, power tower, aerialway pylon etc.

tower:construction seems to be more about architectural design of the tower as far as I can tell.

gdprdatasubect commented 1 year ago

I see your point, but it's kinda hard for me to find a question that describes it without being too vague or it being too material-centered…

Maybe "Which construction method does this mast/tower resemble the most?" and then have a list of example pictures?

westnordost commented 1 year ago

Hm, for me, all the masts on the respective wiki page look the same. Also, for towers, the values are somewhat odd. Is it about the tower, or what is on top? You know, because of the value dome, dish, ....

So, in this regard...

🚧 To be added tag is established and has a useful purpose

tower:construction is already established and useful e.g. for emergency ("what do you see around you?") and navigation

I do not find this convincing. The presence of telecommunication masts yes, but how specifically they were constructed? I don't think so.

mnalis commented 1 year ago

Also, for towers, the values are somewhat odd

yeah, key/value names are sometimes strange in OSM. But as we're are only about using this (well documented and wildly used) tag (and not proposing its renaming), I don't think it should concern us here (we could go all the way back to complaining that highway=traffic_signals is even more odd)

I do not find this convincing. The presence of telecommunication masts yes, but how specifically they were constructed? I don't think so.

Some values might, e.g. tower:construction=dish is likely rarer and more telling than tower:construction=lattice.

But yeah, while I personally have never been lost enough that people asked me to describe construction type of the tower in the middle of nowhere, still there is more than 110k uses of tower:construction, so I'd say it does seem to tell that reasonably many people do care about that tag enough. (The fact that I personally might not be interested in towers at all should thus not be given too much weight)

Still, if included, I guess it might be disabled by default, as average SC user is probably not going to see the utility of that quest... (then again, towers are not all that common, so having it enabled by default might be fine too, like we have for other rare quests of questionable in-real-life usefulness like What's the structure of this bridge?)