Buildings overlay - support editing of buildings with building:use tag

[davidpnewton]

There are considerable numbers of buildings that the new Buildings overlay is not picking up as such and thus not allowing the editing of.

Look at the buildings in the French commune of St Etienne au Mont just to the south east of Boulogne-sur-Mer to see examples of this.

How to Reproduce

Compare way 132262690 with way 132264085 for an example of two buildings directly next to each other. Difference appears due to something with building levels or building roof type tagging.

Expected Behavior Both way 132262690 and way 132264085 picked up as buildings by the overlay and thus editable.

Versions affected Android 14 Streetcomplete 57.0 beta-2

[matkoniecz]

https://www.openstreetmap.org/way/132262690

https://www.openstreetmap.org/way/132264085

buildings with building:use keys currently are skipped:

https://github.com/streetcomplete/StreetComplete/blob/2aa9bb6ccc3fc974636581166fc935e76404de4b/app/src/main/java/de/westnordost/streetcomplete/overlays/buildings/BuildingsOverlay.kt#L51

[mnalis]

Makes sense to me. Unless quest is going to be extended to handle such cases (with special subquestions, confirmations, or whatever), this should probably be added to SC FAQ as it sounds confusing.

[westnordost]

It is pretty much a missing feature to reduce implementation complexity of that overlay.

If this is implemented (by someone), "historic", "ruins", "disused" (etc?) should be handled accordingly. E.g.

building=industrial + building:use=apartments -> "Built as industrial building, now it is apartment building" building=industrial + ruins=yes -> "Built as industrial building, now it is ruins"

I do not intend to work on it in the matter (I put !building:use in the filter deliberately after all) in the foreseeable time because I want to defer work that concerns the UI to after it has been migrated to Compose

[call-me-matt]

I understand and agree to ignore complex buildings. But for a better user experience, I suggest to give it a (greyed out) color code. As it is now, the user thinks the building tag is not correct or the map data not up to date. This triggers experimenting with the data which is contra-productive.

as-is:	to-be:

[westnordost]

Experimenting? You cannot, as you cannot click on it, or can you?

[call-me-matt]

Well, you are right. But when buildings do not show up in StreetComplete, people use other editors to "fix" the building that seems to be not correctly mapped. I have seen it at different locations. I was also confused and searched here before understanding the logic behind. In my point of view a color code can improve the user experience here.

Edit: I just realized that you have already an overlay for "other" buildings. Why not use that one in the meantime for building:use tags until this issue is closed?