House number quest is asked again immediately after solving it

[rhhsm]

I hope what I saw today is not another case of #4258, but I was asked to solve a house number quest several times again after solving it during a quest update download. See screen shot (note it's asking for the house number of the apartment building with house number 4, i.e. the number is already known). Restarting the app made the quest go away. Maybe #5473 was not a complete solution?

Edit: I noticed in the history of the object here https://www.openstreetmap.org/way/1135323961/history that each time I answered the house number quest again, a new edit was made to the object. The house number quest was preceded with an "Is this building still under construction?" quest, which I answered with Yes. That answer apparently resulted in the activation of the house number quest, but not in an edit to the object (it's still under construction on the map).

Versions affected Android 10, StreetComplete 57.1

[westnordost]

Uff. Oh no. Can you add the logs for time when this happened?

[rhhsm]

2024-03-21T16 0.txt I hope this helps. The screenshot is from 16.13 so it must have happened in the few minutes before. There was another building under construction just east of the one I mentioned above that I deleted this morning because it doesn't exist (Way: 1135323962). Let me know if you need more help.

[westnordost]

Summary:

1. 16:11:37.937 - Download starts
2. 16:11:40.290 - You answered MarkCompletedBuildingConstruction for way#1135323961, AddHousenumber, AddBuildingLevels, AddRoofShape are created and persisted
3. 16:11:56.182 - Download finished, data is persisted, quests are created and persisted
4. 16:11:56.459 - Second download starts
5. 16:11:57.365 - Something triggers checking which quests apply for way#1135323961. AddHousenumber, AddBuildingLevels, AddRoofShape are created again.
6. 16:12:11.892 - Download finished, data is persisted. Quests are created.
7. 16:12:12.644 - You answered AddHousenumber for way#1135323961
8. 16:12:13.719 - Persisted created quests from download
9. 16:12:13.979 - Persisted quest creation after answering AddHousenumber quest
10. 16:12:13.905 - You answered AddHousenumber for way#1135323961
11. 16:12:14.347 - You answered AddHousenumber for way#1135323961
12. 16:12:19.514 - You answered AddHousenumber for way#1135323961
13. 16:12:31.249 - You answered AddHousenumber for way#1135323961
14. 16:13:22.186 - You answered AddHousenumber for way#1135323961

Observations:

• It looks like the actual problem occured after the download. Could point 8 and 9 have triggered this behavior? (= quests from download have been persisted and after that quest created as consequence of the answered quests are persisted)

Takeaways for now:

• Copying the log from the log viewer should also include the log level for easier browsing
• Creating/removing edits should be logged, too. Otherwise it is very difficult to divine what edits the user actually did
• the "fetched x elements in y ms" log could probably be removed. It's clear that it is fast on any subsequent fetch since the cache has been implemented

[westnordost]

blocked until new release

[rhhsm]

Had another case with a kerb height quest today https://www.openstreetmap.org/node/9480862703/history (happened while updating quests). Do you wan the log?

[westnordost]

No. Next version will have some more logging, so maybe that will give a hint where this issue comes from.

[ratti]

I believe #5569 is not related to this ticket, but just a buggy attribute dependency. I have commented there how I could resolve that issue for me. For reproduction I added a link to another node that still has the issue.

I cannot reopen #5569 , feel free to check that comment: https://github.com/streetcomplete/StreetComplete/issues/5569#issuecomment-2052136668

Let me know if I can support.

[westnordost]

Since v57.2 we have some additional logging in place. This might help finding the issue. So when this bug appears again, I'd appreciate if you posted the log here.