streetcomplete / StreetComplete

Easy to use OpenStreetMap editor for Android
https://streetcomplete.app
GNU General Public License v3.0
3.66k stars 338 forks source link

SC asking for maxheight quest with maxheight:forward and maxheight:backward present #5609

Closed mxxcon closed 1 month ago

mxxcon commented 1 month ago

How to Reproduce Look at way 1151405188. Screenshot_20240429_191033_Vespucci Screenshot_20240429_191004_StreetComplete

Expected Behavior Maxheight quest should not come up.

Versions affected 57.3

matkoniecz commented 1 month ago

If both are present then maybe adding one extra does not make sense.

I wonder how well it is supported in routers supporting maxheight - but that is a separate question, I guess.

mxxcon commented 1 month ago

If both are present then maybe adding one extra does not make sense.

If maxheight:forward/backward= are present I think adding plain maxheight=* would be wrong..(and maybe there should be a validator for that too.)

What value would you put there? In my example the difference is just 2", but there can be more extreme situations where the difference is multiple feet/meters.

matkoniecz commented 1 month ago

I think that putting either one would not be wrong, with maxheight:forward maxheight:backward overriding maxheight value in own directions - while something processing maxheight only would have at least some info (so probably put lower value?)

but not filling either should not be wrong...

westnordost commented 1 month ago

The suggestion makes sense. If both are specified, not only is there no point in asking for the "general" height, but also if the height for the different lanes is different, it is often due to the tunnel's roof being an arc. Subsequently, a sign for the general height would not make sense and measuring it would also make sense.

westnordost commented 1 month ago

Example:

https://www.google.de/maps/@50.9757463,14.274041,3a,41.1y,8.64h,92.7t/data=!3m7!1e1!3m5!1sNY7QODtROc1daqzowhM7Dg!2e0!6shttps:%2F%2Fstreetviewpixels-pa.googleapis.com%2Fv1%2Fthumbnail%3Fpanoid%3DNY7QODtROc1daqzowhM7Dg%26cb_client%3Dmaps_sv.tactile.gps%26w%3D203%26h%3D100%26yaw%3D156.55505%26pitch%3D0%26thumbfov%3D100!7i16384!8i8192?entry=ttu

mxxcon commented 1 month ago

I also encountered situation with different maxheight per lane in the same direction https://maps.app.goo.gl/P2kadGGVmtK9y6oRA but I'm not sure how to tag such situation and that's probably a different topic.

HolgerJeromin commented 1 month ago

I also situation with different maxheight per lane in the same direction

That would be maxheight:lanes=3.7|3.9|3.7

https://wiki.openstreetmap.org/wiki/Lanes

with a few hundred elements: https://taginfo.openstreetmap.org/keys/maxheight%3Alanes#overview

westnordost commented 1 month ago

added this for the same reason as above.