streetcomplete / StreetComplete

Easy to use OpenStreetMap editor for Android
https://streetcomplete.app
GNU General Public License v3.0
3.92k stars 358 forks source link

Quest proposal: reference value of minor distribution substations in Norway #6033

Closed zabop closed 1 hour ago

zabop commented 2 hours ago

General

Affected tag(s) to be modified/added: ref for minor distribution substations. Question asked: What is the identifier displayed on this substation?

Initially, I would like this quest to be turned on for Norway. I'll answer the questions below with Norway in mind.

Checklist

Checklist for quest suggestions (see guidelines):

Established: yes, see taginfo page for ref.

Useful purpose: having reference values for substations eases identification of them (mapping other values might become easier once we have a reference - this is location dependent). I asked in #osm-infrastructure IRC channel what infrastructure-related StreetComplete quests there could be:

image

Yes. If the substation has a reference value, then that, if it does not, then ref:signed=no, just like it is the case for fire hydrant references.

Both yes. It's not possible to see these values from aerial or satellite imagery. It is very easy to read off these values once someone is standing next to such a substation. Some examples.

Node 9842353095, tagged: ref=1760:

image

Image source.

Way 681412608:

image

Image source.

Way 1063991898

image

Image source

Way 1036467202

image

Image source.

I can go take images with my own camera if we need it due to restrictive Google Street View licencing. Not mapping from them, but seeing that substations tend to have a reference value is I believe ok.

We should take care not to enable this quest in countries where lots of substations are without a reference. I think Norway is a good start. Mappers knowledgeable on their countries' substations could suggest to expand the countries this quest is enabled for.

I am confident I can make a reasonable PR for this quest - I hope the effort required by others is close to 0. There are 16296 cases in Norway where this quest is relevant.

Ideas for implementation

Element selection:

nodes, ways with
substation = minor_distribution
and !name and !ref and noref != yes and ref:signed != no and !~"ref:.*"

Metadata needed: I don't think this is needed.

Proposed UI:

Below are some screenshots form a mockup in Android Studio. (This being a demo there are imperfections - like "Marked Crossing" - but I can fix them. I'll leave some work for after this is approved.)

image Screenshot_20241202_230212 image

Icon suggestion:

image
HolgerJeromin commented 2 hours ago

Thanks for taking the time for this suggestion with very much input. Still this is a duplicate of closed #4106

See this for explanation of rejection: https://github.com/streetcomplete/StreetComplete/issues/4106#issuecomment-2289974399

zabop commented 1 hour ago

Oh I see, thank you!

I copy the rejection reason so that we have it here as well:

I am going to reject this quest suggestion because it would be difficult to ascertain for users whether "some number" / "some letters" on a substation would be the ref, or something else. There could also be several numbers on it, or none. Also, the useful purpose of this information is somewhat unclear.

Would it be possible to save this quest proposal if we find a region which has a consistent substation identifier format? or a sign explicitly spelling out which value is the identifier?

Ie if the identifier is always something like this: ABC-123, then we can make it clear that we are asking for this value. Or, if the identifier value is marked as "Identifier: XXXX" ("Identifier" in native language of the region of course), then again, it's pretty clear what we are asking for and what's "something else".

Gazer75 commented 1 hour ago

Not to be rude or anything, but that is a silly reason to reject it. If people can't see the difference between a name and an ID they got issues.

It could also be added in a note or the change should add a flag to have the edit reviewed by someone.

zabop commented 1 hour ago

I edited the title to better reflect the text I've written.