streetcomplete / StreetComplete

Easy to use OpenStreetMap editor for Android
https://streetcomplete.app
GNU General Public License v3.0
3.82k stars 348 forks source link

Quest: Parking lane #771

Closed rugk closed 2 years ago

rugk commented 6 years ago

General

Affected key(s) (or tags) to be modified: parking:lane Question asked: Are there an parking lanes at the side of the street?

The quest is quite similar to the cycleway quest (https://github.com/westnordost/StreetComplete/issues/139).

Checklist

Checklist for quest suggestions (see guidelines):

Ideas for implementation

Element selection: all streets (maybe limit to some bigger street types), where parking is not tagged as disallowed and parking:lane not set

Metadata needed: possibly, likely at least for street signs

Proposed GUI: very similar to the Cycleways quest, with basic options (parallel, perpendicular, …)

Also no_parking and no_stopping should also be in there, and be represented by the street signs.

matkoniecz commented 6 years ago

all streets (maybe limit to some bigger street types)

So which highway=* values? For example asking that would be absurd for highway=motorway.

Note that you need to exclude roads with nearby amenity=parking areas, some tag these kind of parkings as an areas.

rugk commented 6 years ago

some tag these kind of parkings as an areas.

Well, that's totally incorrect, so… to tag it correctly may not be bad. (One may just need to remove the parking area)

matkoniecz commented 6 years ago

Whatever it is incorrect or not is topic for other discussion - if somebody wishes to retag it is easier to do with JOSM and aerial images + existing OSM data rather than resurveying.

One may just need to remove the parking area

Certainly not, if such tagging is unacceptable then one should retag it (area:highway or something), not remove it.

matkoniecz commented 6 years ago

Example location: https://www.openstreetmap.org/?mlat=52.23883&mlon=20.96935#map=19/52.23883/20.96935 with https://www.openstreetmap.org/way/459464651#map=19/52.23878/20.96978 as an example

westnordost commented 6 years ago

Even if it were totally incorrect (which is not the point), StreetComplete may not ignore that data but rather fix than duplicate that data. To fix it automatically, however, lies outside of the capabilities of the app.

So, Mateusz is correct in saying that streets must be excluded that have a parking area very close-by, using the same mechanism as for cycleways.

Also, care must be taken that all possible findings in the real world for quests are representable in tags. Again, think world-wide. There are many different types of streets.

Am 15. Januar 2018 11:30:11 MEZ schrieb Mateusz Konieczny notifications@github.com:

Whatever it is incorrect or not is topic for other discussion - if somebody wishes to retag it is easier to do with JOSM and aerial images

  • existing OSM data rather than resurveying.

One may just need to remove the parking area

Certainly not, if such tagging is unacceptable then one should retag it (area:highway or something), not remove it.

-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/westnordost/StreetComplete/issues/771#issuecomment-357643026

-- Diese Nachricht wurde von meinem Android-Mobiltelefon mit K-9 Mail gesendet.

HolgerJeromin commented 6 years ago

One main problem IMO is that often you have to split the road (to limit the parking:lane range) which is out of scope for this app.

axre commented 6 years ago

Just want to add that parking space - especially in cities in Germany - is ristricted because of the amount of space a car needs. Sometimes you need to live in the certain area ("Anwohnerparken"), there are restrictions how long you are allowed to park, or when. Sometimes you need to pay something - sometimes not. Sometimes it's a wild combination. https://www.nuernberg.de/imperia/md/verkehrsplanung/bilder/vpl/bewohnerparken_02.jpg

rugk commented 6 years ago

You posted this three times :blush:. Basically yeah, most things are even taggable. Some may not, but in any case we only care for the majority of quests here, everything else is a case for the note feature.

axre commented 6 years ago

@rugk seems like the server got it now despite the error messages in fasthub. "alle guten dinge sind 3" :wink:

matkoniecz commented 6 years ago

@rugk Can you check whatever it is typically taggable (at least in your area) without splitting ways representing roads?

rugk commented 6 years ago

Yes, it is. I'd say in most big cities ways are split enough.

matkoniecz commented 6 years ago

I thought about making PR for this quest, but in my opinion this will have far too many "no" and "splitting required" answers.

rugk commented 6 years ago

Why do you think it would be more than, say e.g. the maxspeed quest?

matkoniecz commented 6 years ago

Parking lane status tends to be split more than maxspeed limits (at least in areas that I know).

All roads have some sort of maxspeed info to tag.

pietervdvn commented 4 years ago

Hey everyone,

I'm gonna bump this quest. For a project where we are measuring street widths, (from curb to curb), this has turned out to be a relevant factor, so I implemented this in a private fork. This project has a limited scope, so that helps to relax some of the tougher questions above.

I've implemented it only for 'parallel_parking' and without the check for parking nearby on residential, unclassified and tertiary roads as these are the relevant ones we need.

And yes, sometimes it is a bit of a mess and requires quite some cutting, which have become in scope of the app by now!

If there is interest in adding this quest, I'll clean up the code and do a PR

signal-attachment-2020-06-05-014946

matkoniecz commented 4 years ago

@pietervdvn

I think that it should work not only for parallel parking (if answering yes to that questions gets recorded as parallel parking then it will result in mistakes). But I am interested in graphics (if P graphics are not included in SC already).

ABstreet makes this quest interesting for me and it is possible that I will work on it

westnordost commented 4 years ago

Does someone know a source where one can find cc-licensed svg art, in particular in this case cars from the top? Most of these icon-finder websites do not actually have free licenses for their art, because there is at least a clause that says "you may not bundle this icon and put or sell it onto your own website".

I know openclipart.org, but there is very little and nothing that looks good. I know that some emoji-sets are cc-licensed (twemoji, some others) but there are no emojis that show cars from the top.

matkoniecz commented 4 years ago

It seems that most of work was done by implementing of bikeway quest and remaining part is making graphics.

Test code without graphics is at https://github.com/westnordost/StreetComplete/compare/master...matkoniecz:parking_lane?expand=1 and needed about 55 minutes so far.

westnordost commented 4 years ago

It seems that most of work was done by implementing of bikeway quest and remaining part is making graphics.

You don't say!

westnordost commented 4 years ago

Regarding your code:

  1. as opposed to sidewalk tagging, I can not find any information on whether mapping parking lanes as areas is accepted practice as well (in certain areas). So maybe the complicated overpass query is not necessary?
  2. Ctrl+F "cycle" in your code
  3. special handling of oneway roads is necessary - if only for display reasons (orientation of graphics that show the cars)
  4. for the "no parking", "no stopping" and "fire lane" graphics, the graphics should be based on the appropriate street sign, so we need to find the different graphics from over the world for that.
  5. maybe limit to places where the is a sidewalk (and surface= something paved?)
  6. Regarding "// TODO is it neeeded isDefiningBothSides = savedInstanceState?.getBoolean(DEFINE_BOTH_SIDES)": No, it's always both sides, even if it is a oneway.
matkoniecz commented 4 years ago

special handling of oneway roads is necessary - if only for display reasons

Opss, I completely missed this

matkoniecz commented 4 years ago

Does someone know a source where one can find cc-licensed svg art, in particular in this case cars from the top? Most of these icon-finder websites do not actually have free licenses for their art, because there is at least a clause that says "you may not bundle this icon and put or sell it onto your own website".

https://thenounproject.com/term/car/1728119/ https://thenounproject.com/term/car/2855626/ (CC-BY) - (suggested by Ketch Ar from the Telegram group)

pietervdvn commented 4 years ago

@pietervdvn

I think that it should work not only for parallel parking (if answering yes to that questions gets recorded as parallel parking then it will result in mistakes). But I am interested in graphics (if P graphics are not included in SC already).

ABstreet makes this quest interesting for me and it is possible that I will work on it

Yes, my tweak only records parallell parking, other types of parking are recorded manually for our project. You can find my graphics here: https://github.com/pietervdvn/StreetComplete/blob/c749364f60cf92d48ecb328aeb8b031491ef498b/app/src/main/res/drawable/ic_parking_lane_puzzle_yes.xml , consider them CC-BY

matkoniecz commented 4 years ago

maybe limit to places where the is a sidewalk (and surface= something paved?)

It is tricky, because asking it in rural areas is often pointless while cities may have roadside parking even without sidewalk...

But I think that requiring would be unfortunately a good idea, even at cost of missing some answers.

On the other hand for A/B Street it would be nice to have full coverage, but probably having two quests of a different intensity would be an overkill.

matkoniecz commented 4 years ago

can not find any information on whether mapping parking lanes as areas is accepted practice as well (in certain areas)

At least in Poland it is often done this way. Not sure whatever it is accepted/preferred (see say https://www.openstreetmap.org/#map=19/52.23125/21.01400 )

westnordost commented 3 years ago

Drew some cars today, was fun. They are supposed to be "normal car" (limo), compact car (like a polo), combi, pickup and van

image

pietervdvn commented 3 years ago

Cool. Might steal them one day ;)

rugk commented 3 years ago

Why do we need so many cars? :see_no_evil: Should it cycle randomly between the car image displayed on the street in the icon/selectable image? :wink:

naposm commented 3 years ago

Now that we have a lane quest this quest would be very useful. Maybe it could be asked before the lanes one so it would be easier to assume the width of the street 🤔 (thinking about this comment: https://github.com/westnordost/StreetComplete/pull/2269#issuecomment-728580077)

Why do we need so many cars? 🙈 Should it cycle randomly between the car image displayed on the street in the icon/selectable image? 😉

I'd put them randomly on a "P" space once the user selects the answer, like this:

Screenshot with cars on "P" spots

I think that maybe it would look "cool"

(By the way OT @westnordost: Thank you very much for the lanes/oneway quests, they were very useful to me! 🤗 Writing here so I don't update a closed issue )

EDIT: From the wiki:

Type of vehicles

If the condition is valid only for some vehicles, use

parking:condition:both:vehicles=motorcar or parking:condition:both:vehicles=goods; bus

So they could actually be useful. The only problem is how it should be asked. A new quest would be too much, but I can't think of any other way at the moment 😔

andrewharvey commented 3 years ago

https://en.wikipedia.org/wiki/Road_signs_in_Australia has signs for Australia, there might be similar wikipedia pages for other regions. Though personally I don't think the signs have to be exact (that could come later to improve localisation).

How I see this quest working is like the cycleway/sidewalk quest.

Ask: Is there a parking lane here? What type?

Illustration shows both sides of the road with ?.

Upon selecting a side you have options from https://wiki.openstreetmap.org/wiki/Key:parking:lane#Parking_spaces

Then immediatly ask again for that selected parking, what is the parking position?

Parking condition would be left to another quest that is unlocked after answering parking lane.

jakecoppinger commented 3 years ago

Is there anything I could work on to help move this forward? :) I haven't done any Kotlin dev before unfortunately, I write TypeScript for work, but might be able to have a crack.

Is this the current closest to ready PR? https://github.com/streetcomplete/StreetComplete/compare/master...matkoniecz:parking_lane?expand=1

I've been working on https://openparkingmap.com (a fork of zlant/parking-lanes with Australian parking signs) so I'm keen to add more parking lane info.

westnordost commented 3 years ago

It's on the roadmap. Right now, I have no idea how you can help.

What will be a problem, as usual, is to display only roads to the user where it is reasonable to ask if there is a parking lane or not. E.g. outside of towns, parking is not expected, but there is no tag that states whether a road is in or outside of a settlement.

mnalis commented 3 years ago

Perhaps it could be asked only on streets with maxspeed:type=XX:urban? It is far from perfect, of course, as it would only catch a subset of eligible streets, but it would catch some of them, and there would be little or no false positives. It might possibly also be extended with maxspeed <= 60 or similar to catch probably-inside-of-settlement streets.

In addition, highway=residential and highway=living_street maybe might be assumed to be inside a settlement?

The quest, if implemented, might still be disabled by default IMHO, as it might generate too many quests. The bigger issue that what roads are inside settlements is how to exclude the road if there is nearby parking already mapped.

westnordost commented 2 years ago

https://user-images.githubusercontent.com/4661658/145690602-6a771c02-6767-461b-ae84-d67dbe819e28.mp4

westnordost commented 2 years ago

Since StreetComplete directly tags parking:lane:<side>=no_parking, no_standing and no_stopping or otherwise (no sign) no, the biggest effort was to display to the user the signs and/or road markings appropriate for the country he is mapping in.

A few examples:

United States (Maryland) Switzerland
device-2021-12-11-210545 device-2021-12-11-210649
South Africa Thailand
device-2021-12-11-211439 device-2021-12-11-210401
BalooUriza commented 2 years ago

In the US, it's more common for places that paint the curbs to use red as no stopping and yellow as no parking.

On Sat, Dec 11, 2021 at 2:34 PM Tobias Zwick @.***> wrote:

Since StreetComplete directly tags parking:lane:=no_parking, no_standing and no_stopping or otherwise (no sign) no, the biggest effort was to display to the user the signs and/or road markings appropriate for the country he is mapping in.

A few examples: United States Switzerland [image: device-2021-12-11-210545] https://user-images.githubusercontent.com/4661658/145690718-154525e7-eb62-4b8f-8a19-57dd269fb9d0.png [image: device-2021-12-11-210649] https://user-images.githubusercontent.com/4661658/145690720-836bf208-a629-4ca1-8dd3-3e675cfea15f.png South Africa Thailand [image: device-2021-12-11-211439] https://user-images.githubusercontent.com/4661658/145690722-edc00998-707a-4d21-a7a7-687275a702bc.png [image: device-2021-12-11-210401] https://user-images.githubusercontent.com/4661658/145690725-2912b6ee-882b-4b4c-b8d8-b90cf2868cea.png

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/streetcomplete/StreetComplete/issues/771#issuecomment-991776256, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAWDFBWIP3FWBAEO3GKJ5SLUQOYW7ANCNFSM4ELYNW3A . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

westnordost commented 2 years ago

According to my research, that depends very much on the state. If you can link to relevant legislation or "photo evidence" (streetview, mapillary showing such markings and in context), i can include it for the state you live in or know about.

1ec5 commented 2 years ago

By the way, this quest reflects the current description of no_parking and no_stopping (which are also consistent with this tagging overhaul). Previously, the documentation made inaccurate claims regarding the United States that would have resulted in “No Parking” being interpreted as no_stopping and “Loading Zone” as no_parking.

fabzgy commented 2 years ago

Thumbs up for this quest from Freiburg, Germany. Our city has no idea how many parking spots do exist.