streetcomplete / StreetComplete

Easy to use OpenStreetMap editor for Android
https://streetcomplete.app
GNU General Public License v3.0
3.83k stars 348 forks source link

Museum type quest #890

Closed ServusWorld closed 2 years ago

ServusWorld commented 6 years ago

General

Affected key(s) (or tags) to be modified: museum Question asked: What type of museum is XY?

Checklist

Checklist for quest suggestions (see guidelines):

Quantity

Although it sounds to be a very specific quest, it'd still show up frequently in cities. I can't compute the total number of quested objects all over europe, but maybe figures from a few cities are representative:

Moreover, I think the quest could be implemented easily using the quest generator.

Ideas for implementation

Element selection: [tourism=museum][!museum]

Proposed GUI: a simple image selection quest

Value Image Image source & license
railway railway https://pixabay.com/de/sbb-historic-depot-erstfeld-uri-1578546/ (CC0)
art image https://pixabay.com/de/architektur-geb%C3%A4ude-infrastruktur-2602014/ (CC0)
apis_mellifera (I think it's strange that a own tag exists for that but maybe that's because bee death is an important topic at the moment) image https://pixabay.com/de/biene-honigbiene-apis-insekt-blume-1575236/ (CC0)
history (tbd)
open_air image https://pixabay.com/de/architektur-haus-alte-geb%C3%A4ude-3159058/ (CC0)
science image https://pixabay.com/de/globus-tag-der-erde-erde-planeten-2269653/ (CC0)
gallery image https://wiki.openstreetmap.org/wiki/File:Malba_Buenos_Aires.jpg (public domain)
technology image https://pixabay.com/de/computer-geschichte-probe-imac-1713573/ (CC0)
local ???
nature image https://pixabay.com/de/das-museum-geschichte-nat%C3%BCrliche-1769069/ (CC0)
transport image https://pixabay.com/de/stra%C3%9Fe-reisen-stadt-zug-3134799/ (CC0)
rugk commented 6 years ago

Wow, thanks! You already did nearly all the research. And, BTW, the general idea LGTM.

I think "local" might refer to local museums, who show stuff of the region, e.g. tradition (i.e. if you speak German: Brauchtum). (Also, one may edit the wiki to clarify that.) Of course it is hard to find a picture for that.

For others some things I've noticed by looking at taginfo/your pictures:

ServusWorld commented 6 years ago

So ... I'll try to respond to all points ...

LGTM thanks! :)

"local" might refer to local museums yes, I speak German :) and I think so too, but since it's about local things, there can't be any general photo... the only thing I could imagine would be a location pin, which doesn't really fit

westnordost commented 6 years ago

While certainly very helpful, it says in the wiki that the tag is "proposed". From the wiki, it is not clear which tag of the three tags used so far should be the "winner". I think this needs to go through the normal proposal and voting process before it can be implemented here.

ServusWorld commented 6 years ago

Oops I read over that. Then of course it has to be sidetracked. By the way, does anyone have experiences on how such a decision works and how lobg it may take?

rugk commented 6 years ago

By the way, does anyone have experiences on how such a decision works and how lobg it may take?

No, but would be interested, too. :smiley:

westnordost commented 6 years ago

It is a well kept secret, only known to the inner core of OSM disciples...

westnordost commented 6 years ago

Just joking, look here: https://wiki.openstreetmap.org/wiki/Proposal_process ;-)

ServusWorld commented 6 years ago

πŸ˜‚ thanks

Codain commented 6 years ago

It would be nice to be able to pick more than one answer, as some museum might match different answers (for instance Science and Technology)

matkoniecz commented 5 years ago

While certainly very helpful, it says in the wiki that the tag is "proposed". From the wiki, it is not clear which tag of the three tags used so far should be the "winner". I think this needs to go through the normal proposal and voting process before it can be implemented here.

Is someone interested in doing that? I may write necessary code, but I am not interested in spending time on reviewing tagging and making proposals (my queue is full of other projects).

It would be nice to be able to pick more than one answer, as some museum might match different answers (for instance Science and Technology)

That is one of things that should be discussed during establishing tagging.

rugk commented 5 years ago

https://wiki.openstreetmap.org/wiki/Key:museum now shows "Status: in use" now, so actually I think this is done. It has been proposed already. :smiley:

westnordost commented 5 years ago

It's just a list of common values as found on taginfo. No research, no proposal, and overall below 1000 elements tagged with that.

On 18 October 2018 16:56:36 CEST, rugk notifications@github.com wrote:

https://wiki.openstreetmap.org/wiki/Key:museum now shows "Status: in use" now, so actually I think this is done. It has been proposed already. :smiley:

matkoniecz commented 4 years ago

To implement this quests someone would need to create list that would be both reasonably short and allow to tag almost every museum.

See also https://github.com/westnordost/StreetComplete/issues/890#issuecomment-430932610

Note that that it can be done by anyone, no programming is needed to do that.

matkoniecz commented 2 years ago

From 2018 https://github.com/streetcomplete/StreetComplete/issues/890#issuecomment-367474589

While certainly very helpful, it says in the wiki that the tag is "proposed". From the wiki, it is not clear which tag of the three tags used so far should be the "winner". I think this needs to go through the normal proposal and voting process before it can be implemented here. westnordost added blocked new quest labels on Feb 21, 2018

Since that time usage increased, https://wiki.openstreetmap.org/wiki/Key:subject also increased but it is result of using it for flags.

It is now marked as "in use" but I still think that going through https://wiki.openstreetmap.org/wiki/Proposal_process is needed - and spot various issues during this, now during implementation. Or even worse, after.

Is anyone interested in doing this? Maybe we should close this issue for now and reopen once this is solved?

matkoniecz commented 2 years ago

Closing, without aversion to adding it once mentioned tagging and documentation issues are resolved.