Refactor - Githubissues

streetcomplete / sc-photo-service

Photo upload service for StreetComplete

MIT License

16 stars 5 forks source link

Refactor #10

Closed westnordost closed 4 years ago

westnordost commented 4 years ago

make code more alike the sc-statistics-service
put functionality into classes (daos, parsers, models,...)
easier setup (no need to execute migrate_db.php)
logging the clean up
cleaning up more (in case there was a bug or manual deletion in the past)
clean-up job takes off where it stopped (in case it is cancelled because it is running too long)

exploide commented 4 years ago

Looks good to me. :)

Except the missing newlines at the end of some files. When strictly following POSIX/Unix, these are per definition not lines which might question if the files are actually text files. But most software will cope with that, so I think it's fine for now. (Maybe your editor is doing this oddity.)

I reviewed but haven't tested the code, but since this software is running on your space anyway and I assume it already does, I'm going to merge it. Thanks.