Refactor to PSR-1 and change config to a class with constants

[r15ch13]

This time it's mostly style changes and changes to config.php :smile:

• Methods to camelCase
• removed ?> and end of file
• added CLI check for cleanup.php and migrate_db.php (just in case the .htaccess fails)
• config.php is now a Class with constants: Config::MAX_UPLOAD_FILE_SIZE_KB (no require 'config.php' in functions)

[westnordost]

removed ?> and end of file

But according to PSR-1:

PHP code MUST use the long <?php ?> tags or the short-echo <?= ?> tags; it MUST NOT use the other tag variations.

[r15ch13]

Oh, that's actually from PSR-2.

[westnordost]

Oh, that's actually from PSR-2.

Okay, weird. So the coding styles do not actually expand on each other.

[r15ch13]

Oh, that's actually from PSR-2.

Okay, weird. So the coding styles do not actually expand on each other, as it is claimed.

I think this is mainly for excluding the ASP Tags <%= and %>. ?> is still used for inline code:

Date: <?php date(); ?> an so on.

[r15ch13]

I don't intend to open the pandora's box of a discussion about whitespaces, the placement of curly braces or function names.

Here are some code examples of widely used PHP projects: PHPUnit, for unit testing: Assert.php Guzzle, an HTTP client: Client.php Symfony, framework: Application.php Laravel, framework: Model.php

You're the project owner, you decide. :smile:

[exploide]

Ok fine then :stuck_out_tongue:

Thank you, I'll merge now. The project looks a bit prettier now. Especially the configuration is much better this way :tada: