streetcomplete / streetcomplete-mapstyle

🌎 Simple, minimalist yet modern map style
https://streetcomplete.github.io/streetcomplete-mapstyle/
GNU General Public License v3.0
41 stars 9 forks source link

Euston Road London rendered weirdly in dark mode #84

Closed peternewman closed 2 years ago

peternewman commented 4 years ago

As title. Needs more investigation.

It looks like a river almost semitransparent blue.

It seems to apply to highway=trunk and highway=motorway but not highway=motorway_link.

They look fine in the light mode.

peternewman commented 4 years ago

To me, switching to blend: translucent in lines-highway-style looks better, then optionally making the highway_color have some transparency.

matkoniecz commented 3 years ago

It looks weird also to me:

https://www.openstreetmap.org/#map=15/50.0879/19.8192&layers=N

screen

Note, railways suffer from similar overlaps but far less severe ones.

westnordost commented 3 years ago

Even though this is kind of a bug in tangram-es, i think it looks quite cool

peternewman commented 3 years ago

Even though this is kind of a bug in tangram-es, i think it looks quite cool

The longer overlap or the dots? It just seems a bit odd to me as it potentially has no or limited relevance to the road (e.g. change in lanes causing a dot).

matkoniecz commented 2 years ago

Even though this is kind of a bug in tangram-es, i think it looks quite cool

For me it looks quite glitchy/confusing but also cool.

westnordost commented 2 years ago

One part of the bug is caused by

https://tangrams.readthedocs.io/en/main/Syntax-Reference/draw/#cap

(cap: round)

tangram-es draws a round cap for each segment of a way, so at the point where there are two consecutive segments, two opposing round caps that complement each other become a circle.

Helium314 commented 2 years ago

Looks less cool, but also a lot less weird/confusing when removing https://github.com/streetcomplete/streetcomplete-mapstyle/blob/2ecce80b365b2eea1e1351ad3abe5f8b355f9a5b/streetcomplete-dark-style.yaml#L46-L51 Very simple to test in https://streetcomplete.github.io/streetcomplete-mapstyle/?provider=jawg The colors might then need some adjustment...

westnordost commented 2 years ago

Feel free to create a PR