streetlives / yourpeer.nyc

The open source repository behind the yourpeer.nyc web application
https://yourpeer.nyc
MIT License
0 stars 0 forks source link

Change "Requires None" to "No documents required to use this service" #118

Open adambard1 opened 4 months ago

adambard1 commented 4 months ago

In the required documents (for any type of service) we can pull a status "None" if that's what the Specialist has defined. But it isn't clear to a user what 'Requires None' means as it has no context. When we show that selection, it should change the statement "Requires None" to "No proofs required"

All other requirements can remain as before, as "Requires [whatever proof it is]"

Sample 'Requires None' currently on YourPeer FE

Screenshot 2024-04-08 at 17 56 17
adambard1 commented 4 months ago

Don't see this fix on test as suggested where it would say "No proofs required" @shakilhossain1 is that because we are simply not showing it, if there are no membership or docs requirements (which is a better solution).

adambard1 commented 3 months ago

@shakilhossain1 can you confirm what you've done here - did you choose to not show "None" at all in the service description field?

adambard1 commented 2 months ago

Can you confirm the status of this issue @shakilhossain1 ? I believe we decided that we did want to show "No proofs required." if a Specialists has selected 'None'

adambard1 commented 2 weeks ago

On live we don't show anything for the 'None' selection, though it is sometimes selected on purpose to make the service stand out from other similar services that would require docs. However there is a bug whereby you can't leave the docs required field empty if you've previously made/validated a selection, so sometimes we select None to remove the previously made selection.

atm on test we are showing the docs required icon but with no info, so that should change. Ideally to "No documents are required to use this service" but if we just want to make sure of no regression then don't show anything if someone has selected None.

Current Live

Screenshot_20240805-201032

Current Test

Screenshot_20240805-183930

doobneek1 commented 2 weeks ago

@jbeard4 when the none option is selected on the Gogetta's back end, the YP does not show anything, but it should be verbose in saying there are no requirements. However, the bug making us select none to remove previous input should be fixed, too.

adambard1 commented 4 days ago

On live we don't show anything for the 'None' selection, though it is sometimes selected on purpose to make the service stand out from other similar services that would require docs. However there is a bug whereby you can't leave the docs required field empty if you've previously made/validated a selection, so sometimes we select None to remove the previously made selection.

atm on test we are showing the docs required icon but with no info, so that should change. Ideally to "No documents are required to use this service" but if we just want to make sure of no regression then don't show anything if someone has selected None.

Current Live

Screenshot_20240805-201032

Current Test

Screenshot_20240805-183930

This is still an issue, please attend to it @shakilhossain1 or @jbeard4 since we cannot deselect the 'None' (/documents/proofs-required) documents required field, so end up with warning icons without any content.