Nextjs refactor: Centering button behavior when viewing a location's summary (mobile) or details (desktop)

streetlives / yourpeer.nyc

The open source repository behind the yourpeer.nyc web application

https://yourpeer.nyc

MIT License

0 stars 0 forks source link

Nextjs refactor: Centering button behavior when viewing a location's summary (mobile) or details (desktop) #48

Open adambard1 opened 1 month ago

adambard1 commented 1 month ago

[ ] If I have been scrolling around and select a pin to view it's details, then click the center button, the selected location should zoom out and remain in view on the map window as centering shifts the map to my location., so I can get a sense of where it is in relation to me.

This matches behaviour on prod.

jbeard4 commented 1 month ago

Fixed Screenshot from 2024-07-23 23-12-06

adambard1 commented 1 month ago

I'm not sure if this is fixed for local NYC views, but given your screenshot, I presume so. However, I don't think we want to show the user's location if they are outside the 26-mile boundary from the center of Central Park—we would probably use the default location at the center of Central Park for this if they're not in NYC. Also (not that there's any reason to do this, I would apply the above suggestion), I'm in the UK, and it doesn't show both locations.

jbeard4 commented 1 month ago

@adambard1 The issue you mentioned has been fixed - it will default to central park if the user's current location is out of range. This is ready for re-review.

adambard1 commented 1 month ago

Yes, works well imo, though perhaps we'll want to have a popup at some point explaining that the user needs to be inside the NYC metro area and to turn on their location to enable centering on their location.