streetlives / yourpeer.nyc

The open source repository behind the yourpeer.nyc web application
https://yourpeer.nyc
MIT License
0 stars 0 forks source link

Nextjs - Fix additional search deletion and operation issues (https://yourpeer-shakil-fix-iss-rhbjp8.herokuapp.com) #54

Open adambard1 opened 3 months ago

adambard1 commented 3 months ago

X is now on the same line, but it only searches and deletes the search term in certain instances

Below video shows only the inability to delete the search term if entered but not executed

https://github.com/user-attachments/assets/ee4e83b2-903d-4b8b-bf2a-21c970ac7a90

adambard1 commented 3 months ago

Shows non-application of search term entered on Filters page and missing no results screen

https://github.com/user-attachments/assets/e93b5048-03d3-4ae5-afd0-b9495f7538d6

adambard1 commented 3 months ago

Search and search deletion don't show any results when a location is selected in map mode on mobile. There are a few different things that happen, such as the map showing no locations or the map not moving, but none show me results or say there are no results (if that's the case)

https://github.com/user-attachments/assets/413dfd36-6332-4a9d-be52-85327b0fa340

adambard1 commented 3 months ago

Search might be broken in the Location details view on desktop (it's not possible in mobile) @jbeard4 , since it did not appear to do anything and the URL has the search query tacked on the end of the location URL (.e.g. this) - my assumption is the expected behavior is when you search in details view, it kicks you back to list view for the results as if you were searching based on the search terms and the filter selections.

But I am not 100% sure, there's a slight possibility that the person may be searching the locations details page itself. We should test that hypothesis expectations.

jbeard4 commented 3 months ago

Still working on this one.

adambard1 commented 3 months ago

Seems to be working

doobneek1 commented 2 months ago

@adambard1 it is working, maybe close the issue.