search

streetmix / streetmix

Streetmix makes it easy for people to design public spaces together.
https://streetmix.net
Other
673 stars 190 forks source link

Standardize all segment elevation variants #1826

Open louh opened 4 years ago

louh commented 4 years ago

e.g. for scooters using the "scooter-elevation" variant, or bike racks using "bike-rack-elevation" variant, we can simplify things by just using the common "elevation" variant for each of them.

andrewgilbert12 commented 4 years ago

The one problem with this is that bike-rack-elevation has three options. Whereas the other elevation variants only have 'road' and 'sidewalk', 'bike-rack-elevation' can be any of ' sidewalk-parallel', 'sidewalk', and 'road'. It doesn't seem that it's possible to reconcile this without having two different types of variant.

On the other hand, there is 'transit-center-elevation', which has a 'high' and 'low' option. It would change the naming, but we could merge that one easily.

'scooter-elevation' looks to be easily mergeable.

andrewgilbert12 commented 4 years ago

Started work in branch https://github.com/streetmix/streetmix/tree/andrewgilbert12/chore/standardize-elevation-property