search

streetslab / dimelo

python package for analysis of dimelo-seq & nanopore modified base data
MIT License
3 stars 5 forks source link

Dblock #28

Closed reetm09 closed 2 years ago

reetm09 commented 2 years ago

Merging dblock to main after adding transaction and other minor fixes!

amaslan commented 2 years ago

@reetm09 - all of my tests work! just 2 points: (1) can you re-compile the documentation? it looks like you've added some details in qc_report docstring. (2) what is the rationale behind no longer including conn.close() and adding logic for conn=None? just curious for my own sake. otherwise, this looks great and is ready to merge!

amaslan commented 2 years ago

Updates look great and works on my end with new connection logic in parse_bam. Only super minor suggestion is to remove the numbering "1." for the table reads_sampleName in the qc documentation since there is only one table. Referring to: "After QC, each database contains this table with columns listed below: 1. reads_sampleName." Aside from that I think you are ready to merge and go for it!