streetturtle / awesome-wm-widgets

Widgets for Awesome Window Manager
http://pavelmakhov.com/awesome-wm-widgets/
MIT License
2.16k stars 279 forks source link

Allow specifying the maximum song title length before scrolling begins in spotify-widget #366

Open chaorace opened 2 years ago

chaorace commented 2 years ago

Allows specifying a max title length via a new title_scroll_length option before spotify-widget begins scrolling it. If -1 is specified, the widget will never scroll (this is also how the pre-existing max_length configuration option works works). The originally hardcoded maximum scroll area width has been retained as the default option value.

Note that only the song title is ever scrolled by the widget (this is the pre-existing behavior) and so only the length of the title will count towards the scroll area length.

streetturtle commented 2 years ago

This looks cool! Thanks! I would like to test it for some time (I'm not 100% sure about using scrollable widget, as there was some note in docs about how resource-greedy it might be - not sure, though, if it's still the case if widget does not scroll)

chaorace commented 2 years ago

@streetturtle The widget already scrolls, though. I actually introduced this PR specifically because I hated the scrolling and wanted a way to turn it off