search

streetturtle / awesome-wm-widgets

Widgets for Awesome Window Manager
http://pavelmakhov.com/awesome-wm-widgets/
MIT License
2.12k stars 274 forks source link

OpenWeatherMap API 2.5 deprecation #442

Open Ryuno-Ki opened 4 months ago

Ryuno-Ki commented 4 months ago

Hey there :wave:

I recently received an e-mail by OpenWeatherMap that they are going to sundown API 2.5 in June this year.

They were so kind to link to https://openweathermap.org/one-call-transfer for an upgrade path.

Since I'm using OpenWeatherMap myself I was wondering whether you would be open to a PR upgrading to the new API? How can we communicate that a new API token will be required? I couldn't come up with a good way for this myself.

Ryuno-Ki commented 2 months ago

I've opened #448 in case someone else is relying on Weather reporting as well. No forecast yet (as I wrapped my head around how to get the current weather rendered in Lua).

Ryuno-Ki commented 2 months ago

FWIW I just spotted #394 which uses another service. I could imagine allowing the awesome people to choose which service they want to use as WeatherAPI is also requiring an API key (but does not need a change in its API in rc.lua).

Opinions?

streetturtle commented 2 months ago

The widget in #394 is visually different from this one, I'll ask the maintainer if they would be ok to move it in this repo. I think it would be too much work to make theese widgets look the same, as the data those two APIs (OWM and wttr) return could be different.

streetturtle commented 2 months ago

Hey @Ryuno-Ki, thank you for starting this migration! I think the best way to proceed with migration to the weatherapi.com would be to create a new widget (we can call it weather-api-widget for example) and add a deprecation notice to this one's readme. New users will definitely check the readme, and hopefully existing will check it, when the OWM API stops working.
What do you think? If you ok with it, please add a new widget, and I'll take care of the deprecation notice in the readme.

Ryuno-Ki commented 2 months ago

Hey @streetturtle,

sounds fine with me. I'll set aside some time this week to rework my PR. I marked it as a WIP in the meantime.

For the record: Last weekend I received an e-mail by OpenWeatherMap informing me that 2.5 is sundowned. Apparently one of my API keys was moved to the Free Tier (haven't logged in yet to verify). I don't know yet whether I can test the 3.0 API with it, but if it does, I can update both widgets.