search

streetwriters / notesnook-importer

Import your notes from any app into Notesnook
https://importer.notesnook.com/
GNU General Public License v3.0
48 stars 9 forks source link

[OneNote Importer] Multiple page parts not imported #27

Closed altano closed 2 years ago

altano commented 2 years ago

A page can have multiple areas in the canvas. I'll call them "parts" since I don't know the actual term. OneNote sometimes creates these automatically, but you can create them by clicking in the empty area of the page. They will get small bars at the top to allow them to be moved around.

Describe the bug When a page has multiple page parts, only the first one is imported. The rest are gone.

To Reproduce

  1. Have a OneNote note with multiple page parts
  2. Go to Notesnook Importer and perform OneNote import. Download .nnbackup file.
  3. Go to Notesnook desktop and click Settings -> Backup & restore -> Restore backup -> Select .nnbackup

Expected behavior All page parts are present and visible.

Screenshots Example of how to create these page parts: https://user-images.githubusercontent.com/1009/132159664-8d459171-49e9-44c0-bd73-a55df3c3ebf1.mp4

Bug repro: OneNote Notesnook
image image

Desktop (please complete the following information):

Additional context

In my opinion, this is a high severity issue

thecodrr commented 2 years ago

Alright. As part of streetwriters/notesnook#296, I am currently adding support for OneNote in the new importer.

This is not possible. Notesnook notes do not support absolutely positioned content — everything flows down. The of course means a loss of context.

Is there some way we can preserve this context without absolutely positioning things?

altano commented 2 years ago

Oh, to be clear, I don’t care about the layout. Just the lost, not imported content.

If the importer grabbed both parts and just made one come right after the other I would be happy. Maybe just put a line between them while importing or something?

Thanks for working on this btw!

altano commented 2 years ago

~Can still reproduce in Importer v1.2.1~

altano commented 2 years ago

EDIT: False alarm, ignore the previous comment. I just tested with the latest import zip and this is 100% fixed. Sorry about the noise.