search

streetwriters / notesnook-importer

Import your notes from any app into Notesnook
https://importer.notesnook.com/
GNU General Public License v3.0
62 stars 10 forks source link

[OneNote Importer] Password protected sections are silently skipped #28

Closed altano closed 2 years ago

altano commented 3 years ago

Describe the bug Password protected sections are silently skipped. I wasn't aware the section was not imported until I saw the empty topic (no notes) in Notesnook.

I am having trouble getting all notes to import (see https://github.com/streetwriters/notesnook-importer/issues/29) so this issue MIGHT be a duplicate of that one, rather than there actually being a password-protected section limitation.

To Reproduce

  1. Have a OneNote document with a password protected section
  2. Go to Notesnook Importer and perform OneNote import. Download .nnbackup file.
  3. Go to Notesnook desktop and click Settings -> Backup & restore -> Restore backup -> Select .nnbackup

Expected behavior I would expected the importer to say "SUCH AND SUCH NOTE is not being imported because it is password protected"

Screenshots n/a

Desktop (please complete the following information):

Additional context

In my opinion, this is a high severity issue

thecodrr commented 2 years ago

These sections are ignored by the OneNote API (I think). I'll investigate some way to tell the user which section exactly is getting skipped but that's about it.