search

streetwriters / notesnook-sync-server

Sync server for Notesnook (self-hosting in alpha)
https://notesnook.com/
GNU Affero General Public License v3.0
389 stars 17 forks source link

S3 external url protocol only http? #6

Closed dyw770 closed 1 month ago

dyw770 commented 1 month ago

https://github.com/streetwriters/notesnook-sync-server/blob/b12eb39797c1effcef4e5d4e2f5be0d9a8dc7cf2/Notesnook.API/Services/S3Service.cs#L232

This part of the code restricts the S3 protocol to only HTTP. When I modify the SELF_HOSTED environment variable, it will cause other problems. delete the Protocol = Constants.IS_SELF_HOSTED ? Protocol.HTTP : Protocol.HTTPS, use the protocol in S3_SRVICE_URL instead?

thecodrr commented 1 month ago

~Using an external S3 provider is not supported. The sync server uses self hosted Minio by default which runs as part of the docker-compose.yml and uses HTTP protocol.~

Actually you are right. Let's just use the protocol from the S3_SERVICE_URL.

dyw770 commented 1 month ago

@thecodrr Does this project accept pull requests? I would like to submit a pull request when I discover any issues in the future.

thecodrr commented 1 month ago

@dyw770 sure!