Heic images aren't shown in Windows 10 desktop app

streetwriters / notesnook

A fully open source & end-to-end encrypted note taking alternative to Evernote.

https://notesnook.com/

GNU General Public License v3.0

9.47k stars 578 forks source link

Heic images aren't shown in Windows 10 desktop app #5703

Closed codetheron closed 3 months ago

codetheron commented 4 months ago

What happened?

I can't show photos from my iPhone on my Windows 10 app. Maybe .heic format is not supported by Notesnook on Windows 10? I have installed "HEIF image extension" from Windows Store btw.

Steps to reproduce the problem

created a note on iPhone version of Notesnook
attached a photo from photo gallery with compression enabled
note with above photo is being shown correctly on iPhone
however photo from this note is not being shown in Notesnook app on my Windows 10 - it shows placeholder with small icon of broken image (like in internet browser when there is wrong path to the image)
I can download this photo from Windows app (as heic) and it does show correctly in my IrfanView image shower

Version

3.0.6 Windows 10 / 3.0.7 iOS

Platform/OS

Windows

Relevant log output

No response

thecodrr commented 4 months ago

Notesnook supports whatever is supported by the Chrome browser. Chrome does not natively support HEIC images so what you are seeing is expected.

codetheron commented 4 months ago

Okey, let me say it in different way. I would like to see photos in my notes written on iOS device - on my Windows machine. I don't mind it those are .heic or .jpg. So maybe just covert them do .jpg while compressing?

ammarahm-ed commented 4 months ago

Hey @codetheron the latest version of iOS app (v3.0.8) converts HEIC/HEIF images to jpeg before upload. Let us know if it works now so we can close this. Thanks.

codetheron commented 4 months ago

@ammarahm-ed yes, it works :) Great :)

I have created a test note with 2 images - one compressed. one not compressed.

compressed .jpg is shown correctly in both apps, after downloading has correct size, name and removed exif data - great
uncompressed - is shown correctly on iOS, shown as image frame in Windows app (looks better than before - with nice image placeholder) - but can't be downloaded in Windows app from image context options ("Download attachment").

What's interesting - both of those images aren't being shown in Atachments manager - older ones are there in 'images' category.

ammarahm-ed commented 4 months ago

@ammarahm-ed yes, it works :) Great :)

I have created a test note with 2 images - one compressed. one not compressed.

compressed .jpg is shown correctly in both apps, after downloading has correct size, name and removed exif data - great

uncompressed - is shown correctly on iOS, shown as image frame in Windows app (looks better than before - with nice image placeholder) - but can't be downloaded in Windows app from image context options ("Download attachment").

What's interesting - both of those images aren't being shown in Attachments manager - older ones are there in 'images' category.

Can you go to Note Properties -> Attachments and see if both images are listed there. Can you try running file check on each image?

I just tested with an HEIC image compressed/uncompressed both work normally. I am able to preview and download the image on all devices.

codetheron commented 4 months ago

Ok, I've tested it again with new photos - yes - now both resized and original images are stored as .jpg and shown correctly in iOS / Win 10 app. File sizes are reasonable - 532 KB vs 4.2 MB. They are both visible in Attachment manager.

I would change one thing though - resized image is named IMG_1234.jpeg but compressed image is named as FullSizeRender.heic.jpeg. As most of the images will be resized (as suggested by app) - maybe it would be good idea to give it some more distinctive name like IMG_1234_resized.jpg or something.

codetheron commented 3 months ago

I have tested current version and it seems that everything is OK - resized / compressed pictures are nicely named and synced from iOS to desktop, Great! Thanks :)