streetwriters / notesnook

A fully open source & end-to-end encrypted note taking alternative to Evernote.
https://notesnook.com/
GNU General Public License v3.0
10.39k stars 639 forks source link

Images Imported From Evernote No Longer Work #6315

Open kevinjavitz opened 3 months ago

kevinjavitz commented 3 months ago

What happened?

They worked at first, but I don't think that notesnook downloaded them, rather it seems to have just been hotlinking the Evernote image source, now it seems Evernote has disabled hotlinking the images from their servers. This is a pretty big issue, any chance of an update that will somehow fix it for my existing notes? (1000s)

Steps to reproduce the problem

Import notes from Evernote that contain images, Evernote will block the hotlinking, they will stop working

Version

3.0.11-2eb4911-desktop

Platform/OS

Windows

Relevant log output

No response

thecodrr commented 3 months ago

@kevinjavitz can you check now? They should be working.

kevinjavitz commented 3 months ago

I checked they still don't work, here is an example that I published: https://monogr.ph/6614d16e828282d6aac8ca34/

On Fri, Aug 9, 2024 at 12:11 PM Abdullah Atta @.***> wrote:

@kevinjavitz https://github.com/kevinjavitz can you check now? They should be working.

— Reply to this email directly, view it on GitHub https://github.com/streetwriters/notesnook/issues/6315#issuecomment-2277234586, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACONYVPL5YX7XG3BPU22B3ZQROIZAVCNFSM6AAAAABMESYA7KVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENZXGIZTINJYGY . You are receiving this because you were mentioned.Message ID: @.***>

thecodrr commented 3 months ago

The importer doesn't hotlink images so not sure why they aren't working. Were they working before? When did you do the import? And did you import using ENEX files?

kevinjavitz commented 3 months ago

The images were working before, then they stopped. Here is the enex and notesnook version of the enex file. I tried reimporting and the images work again, so not sure what made it stop working after awhile, maybe you can check the code.

https://1drv.ms/u/s!Ak6sV2dGq9H6kbVqp7vwigMCquA4Mg?e=XLf0XL

https://1drv.ms/u/s!Ak6sV2dGq9H6kbVpqDwQHQSgp81QEQ?e=ueO5Bb

EmilioMeneses commented 3 months ago

This error is also for me a huge issue. I am stuck in Evernote. I have over 5k notes that are not correctly imported