stremlau / html5_notifier

HTML5 Notifier plugin for roundcube
ISC License
64 stars 32 forks source link

no translation if html5_notifier_duration is 0 #29

Closed hoedlmoser closed 8 years ago

hoedlmoser commented 8 years ago

if I set html5_notifier_duration to 0 (either in config.inc.php or by user) translation gets lost in configuration dialog.

to solve that issue I applied following patch.

--- html5_notifier.php.orig 2016-03-22 19:49:56.593093040 +0100
+++ html5_notifier.php  2016-03-25 13:23:41.041071661 +0100
@@ -30,10 +30,11 @@
         {
             $this->add_hook('new_messages', array($this, 'show_notification'));
             $this->include_script("html5_notifier.js");
-            if ($RCMAIL->action != 'check-recent')
-            {
-                $this->add_texts('localization', array('notification_title', 'ok_notifications', 'no_notifications', 'check_ok', 'check_fail', 'check_fail_blocked')); //PR�ZESIEREN
-            }
+        }
+
+        if ($RCMAIL->action != 'check-recent')
+        {
+            $this->add_texts('localization', array('notification_title', 'ok_notifications', 'no_notifications', 'check_ok', 'check_fail', 'check_fail_blocked')); //PR�ZESIEREN
         }
     }
stremlau commented 8 years ago

Thank you!

hoedlmoser commented 8 years ago

I appreciate your work on this plugin.