strengejacke / sjstats

Effect size measures and significance tests
https://strengejacke.github.io/sjstats
189 stars 21 forks source link

Fix check issues #120

Closed strengejacke closed 4 months ago

strengejacke commented 4 months ago

@mattansb I see this error:

  + t.test(mtcars$mpg, mtcars$hp, data = mtcars, paired = TRUE)
  + ## Don't show: 
  + }) # examplesIf
  > data(sleep)
  > t_test(sleep, "extra")
  Error in cohens_d(x = t_formula, data = tdat, mu = mu, alternative = alternative,  : 
    could not find function "cohens_d"
  Calls: <Anonymous> ... <Anonymous> -> <Anonymous> -> eval.parent -> eval -> eval
  Execution halted

There are two occurrences where I call effectsize::cohens_d() in the code (see https://github.com/strengejacke/sjstats/blob/519f66a6c9406f83a5851f6efc1c2409b22729b3/R/t_test.R). Why is this test failing? Any ideas?

mattansb commented 4 months ago

This is related to https://github.com/easystats/effectsize/issues/636.

I will send it to CRAN now.

strengejacke commented 4 months ago

Ah, good to know. Thanks!