Filter for complete cases in a way that works with groups

strengejacke / sjstats

Effect size measures and significance tests

https://strengejacke.github.io/sjstats

189 stars 21 forks source link

Filter for complete cases in a way that works with groups #93

Closed jennybc closed 5 years ago

jennybc commented 5 years ago

Prepare for the fact that tidyr::nest() returns a grouped data frame in v1.0.0 and higher. The existing filter() call fails.

In our tidyr revdep check, we see problems with examples and tests:

https://github.com/tidyverse/tidyr/blob/master/revdep/problems.md#sjstats

jennybc commented 5 years ago

Sorry this diff looks so large. I imagine it's a line ending issue. Let me know if you want me to attempt to deal with that properly.

strengejacke commented 5 years ago

Thanks, will merge now. When do you expect tidyr submit to CRAN?

jennybc commented 5 years ago

When do you expect tidyr submit to CRAN?

We haven't set a specific goal but I'm going to say "within the next couple of weeks". So having revdeps adjust themselves on CRAN in advance is super helpful.