Add additional logic to CLI

stresearch / gaia

Global AI Accelerator - GAIA: Code for training and running climate surrogate models

https://stresearch.github.io/gaia/

4 stars 0 forks source link

Add additional logic to CLI #25

Closed ktrapeznikov closed 2 years ago

ktrapeznikov commented 2 years ago

So there is an issue where some default config stuff is dependent. For example, if you specify model_type in CLI, it won't load the default config... same goes for dataset. So I think we need to do a two step CLI parsing:

get the default config
get some of these higher level things like dataset name and model type from CLI if they exist so maybe make you Config class a function of these
reload the default configs for those
overwrite any defaults with CLI inputs

ktrapeznikov commented 2 years ago

@blooyay use the branch that's created automatically for this issue https://github.com/stresearch/gaia/tree/25-add-additional-logic-to-cli

ktrapeznikov commented 2 years ago

@blooyay Here https://github.com/stresearch/gaia/blob/7299b6130a9298cf302f34cfce43b8816d8f311b/gaia/config.py#L9 you can just make the init as a function of dataset and model_type