search

stretchr / gomniauth

Authentication framework for Go applications.
MIT License
639 stars 52 forks source link

Dropbox support no longer available? #36

Open jamiefoster opened 9 years ago

jamiefoster commented 9 years ago

I see that Dropbox support was added a while back but it seems gone now.

Was it removed?

Thanks, Jamie

matryer commented 9 years ago

It's here - https://github.com/maggit/gomniauth/commit/ad5f3a9848de682d12308b019a2b311a5ac76b8e

Trying to get a PR.

maggit commented 9 years ago

Hey @matryer sorry I took so long to respond, had a lot on my plate lately. I worked on the dropbox support but I ran into an issue, maybe together we can figure it out the best way to solve it. Basically access_type, and approval_prompt are "unknown" parameters for dropbox, you can check the documentation https://www.dropbox.com/developers/core/docs#oa2-authorize

screen shot 2015-08-28 at 4 09 31 pm screen shot 2015-08-28 at 4 09 21 pm

I was thinking on removing the extra parameters on GetBeginAuthURL perhaps using regular expressions or if you have any other suggestion, please let me know.

oauth2.GetBeginAuthURLWithBase(provider.config.Get(oauth2.OAuth2KeyAuthURL).Str(), state, provider.config)

we need to remove: access_type=&approval_prompt=&