stretchr / goweb

A lightweight RESTful web framework for Go
632 stars 61 forks source link

Should the goweb `import` path include v2? #10

Closed matryer closed 11 years ago

matryer commented 11 years ago

Should the Goweb import path include the version number?

i.e.

import (
  "github.com/stretchrcom/goweb/v2"
)

The namespace would still be goweb allowing clean code.

tylerstillwater commented 11 years ago

Seems to go against go patterns.

It's not our job to manage the version for our users. They can go get -u if they want to update, or checkout a specific tag if they want an older version.

On May 28, 2013, at 2:18 PM, matryer notifications@github.com wrote:

Should the Goweb import path include the version number?

i.e.

import ( "github.com/stretchrcom/goweb/v2" )

The namespace would still be goweb allowing clean code.

— Reply to this email directly or view it on GitHub.

matryer commented 11 years ago

Let's put this to the wider Go community and see what they say. I know http://labix.org/mgo include the version (albeit in a different format)

tylerstillwater commented 11 years ago

Sounds good

On May 28, 2013, at 2:28 PM, matryer notifications@github.com wrote:

Let's put this to the wider Go community and see what they say. I know http://labix.org/mgo include the version (albeit in a different format)

— Reply to this email directly or view it on GitHub.

matryer commented 11 years ago

however, it would mean the Goweb version would be:

github.com/stretchrcom/goweb/v2/goweb
matryer commented 11 years ago

... unless we just keep it as github.com/stretchrcom/goweb/v2 and rely on the package name being properly managed within the code. This would break convention though wouldn't it?

matryer commented 11 years ago

Decided to not do this.