search

stretchr / goweb

A lightweight RESTful web framework for Go
632 stars 61 forks source link

Over-eager path matching #77

Closed matryer closed 10 years ago

matryer commented 10 years ago

This path: 

/people/{people}/***

is matching:

/people

Where it shouldn't be.

tylerstillwater commented 10 years ago

Weird. Is this a regex thing? If so I can look at it.

Sent from my iPhone

On Dec 16, 2013, at 12:09 PM, Mat Ryer notifications@github.com wrote:

This path:

/people/{people}/*** is matching:

/people Where it shouldn't be.

— Reply to this email directly or view it on GitHub.

matryer commented 10 years ago

I’ve fixed it for now… but I think we should rewrite the path matching stuff in Goweb to use RegEx. It’s better designed. Let’s look at it.

On Dec 16, 2013, at 12:19 PM, Tyler notifications@github.com wrote:

Weird. Is this a regex thing? If so I can look at it.

Sent from my iPhone

On Dec 16, 2013, at 12:09 PM, Mat Ryer notifications@github.com wrote:

This path:

/people/{people}/*\ is matching:

/people Where it shouldn't be.

— Reply to this email directly or view it on GitHub. — Reply to this email directly or view it on GitHub.