search

stretchr / testify

A toolkit with common assertions and mocks that plays nicely with the standard library
MIT License
23.15k stars 1.59k forks source link

TestEventuallyIssue805: flaky test #1411

Closed dolmen closed 8 months ago

dolmen commented 1 year ago

We still have flaky tests. It looks like #865 did not fix everything related to #805 and #835.

$ go test -race -failfast -count 100 -run TestEventuallyIssue805 ./assert 
--- FAIL: TestEventuallyIssue805 (0.00s)
    assertions_test.go:2815: 
            Error Trace:    
            Error:          Should be false
            Test:           TestEventuallyIssue805
FAIL
FAIL    github.com/stretchr/testify/assert  0.451s
FAIL

Cc: @snebel29

brackendawson commented 1 year ago

This dinged us in this PR too: https://github.com/stretchr/testify/actions/runs/5596433158/jobs/10233448218#step:4:1567