Support Pointer to Struct in EqualExportedValues

stretchr / testify

A toolkit with common assertions and mocks that plays nicely with the standard library

MIT License

22.52k stars 1.56k forks source link

Support Pointer to Struct in EqualExportedValues #1517

Closed Lucaber closed 4 months ago

Lucaber commented 7 months ago

This PR allows to use EqualExportedValues with pointers to structs.

Lucaber commented 5 months ago

Any update on this? @dolmen @boyan-soubachov

brackendawson commented 4 months ago

I merged this because after reading the doc I considered that the lack of support for struct pointers was a bug. Having closed #1384 as a dup I see that this was considered a feature and targeted for v1.9.0. @dolmen what are your thoughts here; is it ok to tag v1.8.5 (we're very nearly ready) or would you like me to temporarily take this back out (probably by using a release/1.8 branch)?