search

stretchr / testify

A toolkit with common assertions and mocks that plays nicely with the standard library
MIT License
23.15k stars 1.59k forks source link

README: replace Testify V2 notice with @dolmen's V2 manifesto #1518

Open hendrywiranto opened 9 months ago

hendrywiranto commented 9 months ago

Summary

Remove Testify V2 notice on README.md since it won't happen

Changes

Motivation

According to this announcement https://github.com/stretchr/testify/issues/1089#issuecomment-1812734472 from @dolmen

So, as the current only active maintainer, I'm declaring that v2 will never happen. Or at least a v2 of the github.com/stretchr/testify module with such major breaking changes.

Related issues

Issues that can be closed: https://github.com/stretchr/testify/issues/1089

Antonboom commented 9 months ago

hi!

maybe it's better not to remove, but (in contradict) notice about v2 manifesto?

hendrywiranto commented 9 months ago

hi!

maybe it's better not to remove, but (in contradict) notice about v2 manifesto?

Yes, I think that's also a good idea. I'm thinking if maintainers want to link the manifesto instead I will just change the MR

Lets wait his response maybe?

dolmen commented 9 months ago

Yes, linking to my manifesto would be better. In a normal world I would have made the change in the README myself, but as I am not allowed to merge my own PRs, I'm relying on other contributors to submit such patches. 😓

hendrywiranto commented 9 months ago

Thanks for the answer, I have updated the readme with the manifesto Please tell me if you think there is a better wording for this

Antonboom commented 8 months ago

@hendrywiranto also grep "testify v2" e.g. https://github.com/stretchr/testify/blob/master/doc.go

hendrywiranto commented 8 months ago

thanks for the reminder @Antonboom

MovieStoreGuy commented 8 months ago

Hi,

I am relatively new comer to the maintainers group for this, I mostly come from the opentelemetry collector contrib where I use this heavily, and also internally here at Altassian.

As slow as it has been for V2 (apologies for those asking for it), I think it should be the ambition of 2024 to see v2 released.

Let me follow up with @boyan-soubachov on this and we can start getting together a more formal roadmap / milestone for V2 if it doesn't already exist.

hendrywiranto commented 8 months ago

Hi @MovieStoreGuy

I'm glad to hear that there is still plan for V2! Hope you guys can figure something out while making sure this repo (V1) is still maintained regularly

Thanks!

dolmen commented 7 months ago

I have proposed a different wording to expose the active debate about v2.