search

stretchr / testify

A toolkit with common assertions and mocks that plays nicely with the standard library
MIT License
22.51k stars 1.56k forks source link

http_assertions: honour the msgAndArgs provided with each assertion #1548

Closed arjunmahishi closed 4 months ago

arjunmahishi commented 4 months ago

Summary

The http assertions do not use the msgAndArgs at all. This commit fixes that.

Related issues

Not directly related, but stemmed from looking into #316

Closes #1324

arjunmahishi commented 4 months ago

I think the existing tests are good enough to prove that there is no regression. None of them are passing the custom message. That ensures backward compatibility.

Actually, let me add a message in some of the existing tests, just for the sake of it.