Open Neokil opened 3 weeks ago
I've just merged #1607, so please rebase and run codegen.
this will close https://github.com/stretchr/testify/issues/1609 too
somehow I cannot add reviewers the to the PR, but maybe @boyan-soubachov, @dolmen, @MovieStoreGuy, @arjunmahishi or @brackendawson can one of you have a look?
Summary
The comments for the require package were just copied over from the assert package when generating the functions. This could lead to confusion because
t.FailNow()
which is some critical information when using this package.Changes
Motivation
When new developers are coming in they most likely did not go through the github-documentation for every package used in the application. But what they do is read the function-docs when they go through code to understand what it is doing. In case of test-cases using both
require
andassert
it gets confusing because the function docs for therequire
package are referencing theassert
package and don't really document the actual function.