stretta / BEAP

BEAP Modular. Berklee Electro Acoustic Pedagogy
300 stars 50 forks source link

new monome Max package break most of the serialosc BEAP devices #120

Open sonoptik opened 6 months ago

sonoptik commented 6 months ago

The new Monome Max Package breaks most of the serialosc BEAP devices

The old interface device was called serialosc.maxpat and the new one is called monome-device.maxpat - https://llllllll.co/t/monome-max-package-2023-update/62725

Looks like the problem is that the new monome-device puts out a string /monome-device/grid/key 0 0 0 where the old serialosc patch would put out /monome/grid/key 0 0 0

Some of the BEAP devices are expecting the old string and also output serialosc in the old format

Screenshot 2023-12-21 at 10 09 27 AM

I can imagine that this new string potentially breaks 1000s of Max patches out there in the wild

stretta commented 6 months ago

Prefix has been part of the monome protocol forever. You can change the argument to set the prefix to whatever you want. My implementation of it is the issue here.

Anyway, I'll look into it. I think what needs to happen is the beap serialosc devices need a way of setting the prefix. This could be done without disturbing the the existing UI by making the prefix an argument?

sonoptik commented 6 months ago

going to hit up Dan, perhaps we can leave BEAP alone and have the default argument of monome-device.maxpat change

sonoptik commented 6 months ago

This could be done without disturbing the the existing UI by making the prefix an argument?

yeah

stretta commented 6 months ago

patch cables perform the role of prefix between beap modules. Maybe the silly thing is the /monome is there at all.

sonoptik commented 6 months ago

I talked to Ben more about this, and I'm not sure exactly what the best move here is, but the best move is probably the simplest. I emailed Dan/Monome; let's see what Dan thinks.

dndrks commented 6 months ago

hi @sonoptik + @stretta -- hope the end of the year is treating you both well :) hopped over here as soon as i got Tom's email!

@sonoptik , i'm not sure why you're seeing that unexpected prefix for a fresh-instantiation of [bpatcher monome-device] or [monome-device]. when i test the new object on my end, i see the expected default of monome:

image image
silly, but here's a compressed patch which sends the expected prefix

----------begin_max5_patcher----------
425.3ociRssaaCCC8Y6uBA8rahsaSVx9UFJFjkYcXirjgjrWxJ5+9jnbVcp6
.1C1D7PRwKmya4Y7FyEvwYem8CVV1a4YYDTDHa1Oi2KtHUBGkFuGbNQGvKRw
7vEOgus2nM8v1NK1t8LbkUw9Fq7VZlQuB79qCPpWbN644PXKUuo40Gpptkud
rG0gJndV+AX5cHzpYzAgWdB0c+zBRe50qKOtorfUe3.Yp2mLaJYOGq48773u
h+yMtg5.XuMaSH7qIzgMnB8WWNJlWdwAyyPYrmkwVNGTYjmg1VqnyIsFkJlV
4bLoBkm8mrlwtSKwAsnQAmVWPJvz5.ot3veCKQa55Ms2iXrsgUZAxZJpfwQs
OZt66uajVzCIMAQ8OzBSnD1DNdgKFeM8d7KY2G+R1c++lcqNVGusUGHS8SOF
M618I1klRtB0eVdSuXD+dJ2YFsxaq97zx9f8ZAmG0BOZzKxIJXCB808ULLLA
V2b1TOBhpWMzE+PA4h5j6Nx0BQMUJeZ44BaXy8g0dzlNyW1+DOUZfLs5Qjzd
4QobdTCEDrQJwMHRKBoqyeO+OzzVviE
-----------end_max5_patcher-----------

just to confirm, you aren't adding any extra arguments to the invocation, right? that would also set the prefix away from its default (which is set here in the JS to /monome).

lmk if i'm missing anything!!

dndrks commented 5 months ago

hi all! hope everyone's well :) just wanted to close the public loop here -- this isn't a monome Max package issue, right, @sonoptik ? if there's anything we can do to help, just let me know here or on our repo. otherwise, @stretta, feel good to close this specific ticket?