search

stretta / BEAP

BEAP Modular. Berklee Electro Acoustic Pedagogy
302 stars 49 forks source link

Hard sync on bp.Oscillator #28

Closed baptistemanson closed 10 years ago

baptistemanson commented 10 years ago

Hello!

Playing with OSC Sync, I noticed the example is not using the latest version of OSC (latest uses a 0-5V sync inlet, the one in the example expects a signal -5/5V).

I was looking at the bp.Oscillator implementation. The cycle~ object was not patched in HEAD to the sync entry. All the other waveforms were patched, but not this one. Is there any good reason not to do it? Aliasing?

Best,

baptistemanson commented 10 years ago

I updated the example. See the PR.