search

strichliste / strichliste-backend

Strichliste Backend
https://www.strichliste.org
Other
24 stars 14 forks source link

Upgrade to Symfony 5, remove support for PHP < 8.0 #73

Closed m-ober closed 2 years ago

m-ober commented 2 years ago

This PR upgrades the application to Symfony 5, which is the current LTS version and will get security updates until 11/2025.

Support for PHP versions older than 8.0 is removed, as security support for 7.4 will end 11/2022. The version constraint also no longer allows all 8.x versions, that is, PHP 8.2 (and newer) is currently excluded, as it remains to be seen if there are any incompatibilities.

Furthermore, the composer.lock is removed from the .gitignore [1].

[1] https://getcomposer.org/doc/01-basic-usage.md#commit-your-composer-lock-file-to-version-control

schinken commented 2 years ago

Thanks for the PR! Funny thing: I also updated projects to 5.4 today at work :D I think I will create a new bundle tomorrow, or at least this week, if that is ok?

m-ober commented 2 years ago

No hurry - thanks for the fast merge :)

schinken commented 2 years ago

Is there a way to still be backwards compat? or should I just upgrade my PHP? :D

Fatal error: Composer detected issues in your platform: Your Composer dependencies require a PHP version ">= 8.0.2". You are running 7.4.30. in /Users/schinken/Downloads/strichliste/vendor/composer/platform_check.php on line 24

m-ober commented 2 years ago

It should be possible to add 7.4 to the composer.json again, but I think only supporting 8.0 and up is acceptable, because 7.4 is EOL by the end of the year: https://www.php.net/supported-versions.php