search

stride-nyc / remote_retro

Free, world-class retrospectives
https://remoteretro.org/
MIT License
577 stars 65 forks source link

asdf-erlang pre-install requirements not included in setup script #490

Open dplain90 opened 6 years ago

dplain90 commented 6 years ago

As a developer, I want to use the install script to complete erlang/elixir setup on my machine. So that I can quickly and easily have a working dev environment.

By Way Of Explanation:

Currently, the Erlang installation via asdf fails because pre-installation requirements have not been completed per asdf-erlang.

Building Erlang/OTP 20.3 (asdf_20.3), please wait...
Configure failed.
./otp_build: line 319: autoconf: command not found
make: *** No rule to make target `clean'.  Stop.
/Users/danplain/.asdf/plugins/erlang/kerl-home/builds/asdf_20.3/otp_src_20.3/configure  --cache-file=/dev/null CC=clang DED_LD=clang DED_LDFLAGS=-m64\ -bundle\ -bundle_loader\ /Users/danplain/\.asdf/plugins/erlang/kerl-home/builds/asdf_20\.3/otp_src_20\.3/bin/x86_64-apple-darwin17\.7\.0/beam\.smp --enable-darwin-64bit --with-ssl=/usr/local/opt/openssl
./otp_build: line 338: ./configure: No such file or directory

=== running autoconf in lib
./otp_build: line 319: autoconf: command not found
make: *** No rule to make target `clean'.  Stop.
/Users/danplain/.asdf/plugins/erlang/kerl-home/builds/asdf_20.3/otp_src_20.3/configure  --cache-file=/dev/null CC=clang DED_LD=clang DED_LDFLAGS=-m64\ -bundle\ -bundle_loader\ /Users/danplain/\.asdf/plugins/erlang/kerl-home/builds/asdf_20\.3/otp_src_20\.3/bin/x86_64-apple-darwin17\.7\.0/beam\.smp --enable-darwin-64bit --with-ssl=/usr/local/opt/openssl
./otp_build: line 338: ./configure: No such file or directory

Please see /Users/danplain/.asdf/plugins/erlang/kerl-home/builds/asdf_20.3/otp_build_20.3.log for full details.

Acceptance Criteria:

Option A : bin/install_erlang_and_elixir_with_dependencies includes a step prior to installing Erlang via asdf, to install any prerequisites. The script would have to adjust and handle different setups based on the user's OS.

Option B : A link is included to the asdf-erlang documentation in README.md, instructing the developer to handle pre-install requirements.

Helpful Links:

vanderhoop commented 6 years ago

Thanks so much for writing this up, @dplain90. The links are particularly helpful.

@plantfansam @fweep Curious what you two make of this particular issue, as you're both linux folks, and this would effect both mac users and linux folks (to say nothing of windows users, which is a whole other bowl of grease). We could go the Option A route (see above), and allow users to opt in to the script handling the asdf-erlang installation pre-reqs automatically (using brew [if detected] on mac, and apt-get on linux machines), but there's a maintenance burden there, in that if the asdf-erlang requirements change, we won't know about it until the script breaks for an innocent dev. Option B puts more of a burden on interested developers coming to the project, and is more of a barrier for entry (I think).

vanderhoop commented 5 years ago

@dplain90 Any interest in taking on option B? It's low-cost, and will keep people from getting bit. Lemmeknow!