stride-nyc / remote_retro

Free, world-class retrospectives
https://remoteretro.org/
MIT License
577 stars 65 forks source link

Add: Tabindex to labels for facilitators #584

Closed MakerTim closed 2 years ago

MakerTim commented 3 years ago

Description of Change(s) Introduced: Added tabindex to the changeable labels (only for facilitators) so they can tab to the next label Now it tabs first to the vote button, what can be very annoying / confusing. Small quality of life improvement

Description of Testing Applied: (if applicable) Make a Retro, make multiple labels and tab trough them, You will go to the next label instead of first selecting the vote button(s)

Relevant github Issue: (if applicable)

CLAassistant commented 3 years ago

CLA assistant check
All committers have signed the CLA.

MakerTim commented 3 years ago

@vanderhoop did i do something wrong or was there no time yet to look into it?

vanderhoop commented 2 years ago

hey @MakerTim, thanks for opening this, and apologies for the delay. been fighting off some burnout, and finally feeling recharged on RR.

While I understand the desire to tab to the next label, it's a bit of an accessibility violation for folks who rely on keyboard navigating and want to go to vote buttons for a given group.

That said, the feature outlined in #583 (tabbing directly to the next group label input) will be implicitly addressed as a side effect of breaking up the 'labeling + voting' stage into two distinct stages (labeling, then voting), as there will be fewer UI controls on the screen in the given stages. And thankfully, the breakup of the stage is necessitated by some other UX oddities that I aim to fix in the near term. Namely, that facilitators sometimes accidentally advance the retro to the action items stage after labeling but before users have had a chance to vote.

vanderhoop commented 2 years ago

Hey @MakerTim, the split of labeling and voting into distinct stages has been shipped, so tabbing between label inputs now occurs naturally for facilitators, so I'm going to close this!