stride3d / stride

Stride Game Engine (formerly Xenko)

https://stride3d.net

MIT License

6.49k stars 941 forks source link

style: Update launcher brand icons #2345

Closed minktusk closed 2 months ago

minktusk commented 3 months ago

PR Details

Replace old brand icons for new brand icons

Related Issue

Any, just some icons change

Types of changes

[x] Docs change / refactoring / dependency upgrade
[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist

[ ] My change requires a change to the documentation.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.
[x] I have built and run the editor to try this change out.

Jklawreszuk commented 3 months ago

Thanks, It looks like this is your first PR. I have a question, where did you get the social icons from? Unfortunately, some look to be of lesser quality than the old ones

minktusk commented 3 months ago

Thank you for reply, well, I get them from the official brand pages, then resize it

VaclavElias commented 3 months ago

Could we use SVG, if XAML supports that?

Doprez commented 3 months ago

https://uxwing.com/x-social-media-round-icon/ Im not sure if these are better for quality @Jklawreszuk but it seems like the licenses should be good.

They also provide SVG if you want to try that route and see how they are.

Jklawreszuk commented 3 months ago

@minktusk Oh, I see. Like @Doprez suggested, try to find SVG images and try to export them into png files (i.e using Inkscape) - this way you can be sure that the images will be rendered correctly :) Don't forget to add the license to these logos in the https://github.com/stride3d/stride/blob/master/LICENSE.md file 😊

Jklawreszuk commented 3 months ago

If WPF supports SVG file format then you can also replace pngs directly if you wish so. It shouldn't cause much lag

minktusk commented 3 months ago

Thanks, I will try change the icons to SVG and see if it works properly!

minktusk commented 3 months ago

Sorry for taking so long to update this pull request. I wasn't able to make it run SVG files. Honestly, I don't know if it's because XAML doesn't have support for it, or because I just don't know how to use XAML with SVG. So instead of using SVG, I just export them all to PNG using Inkscape ( Recommended by @Jklawreszuk ).

PS: I also changed all mentions in the code from Twitter to XTwitter!

VaclavElias commented 2 months ago

I found this (also as NuGet) but have no experience with it, also not sure if there are other alternatives. Probably, we should keep whatever has less gears and is easier to maintain?

https://elinamllc.github.io/SharpVectors/

Eideren commented 2 months ago

Not sure about svg but xaml supports embedded vectors, see https://github.com/stride3d/stride/blob/master/sources/editor/Stride.Assets.Presentation/View/ImageDictionary.xaml There's a couple of tools built to make the conversion, lookup svg to xaml In any case, having them as bitmaps is fine too, I'll merge this one with the rest this week end

Eideren commented 2 months ago

Thanks !