stride3d / stride

Stride (formerly Xenko), a free and open-source cross-platform C# game engine.
https://stride3d.net
MIT License
6.65k stars 957 forks source link

Pack target crashes #2358

Closed azeno closed 2 months ago

azeno commented 5 months ago

Release Type: Official Release

Version: 4.2.0.2188

Platform(s): Windows

Describe the bug Invoking the Pack target on a Stride based project crashes:

1>------ Build started: Project: VL.Stride.DefaultAssets, Configuration: Debug Any CPU ------
1>Assembly [VL.Stride.DefaultAssets, Version=2024.6.0.0, Culture=neutral, PublicKeyToken=null] has already been processed, skip it.
1>VL.Stride.DefaultAssets -> C:\Users\elias\source\repos\vvvv\VL.StandardLibs\VL.Stride.DefaultAssets\lib\net8.0\VL.Stride.DefaultAssets.dll
1>
1>Unhandled Exception: System.TypeInitializationException: The type initializer for '<Module>' threw an exception. ---> System.IO.FileNotFoundException: Could not load file or assembly 'System.Runtime, Version=8.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' or one of its dependencies. The system cannot find the file specified.
1>   at .cctor()
1>   --- End of inner exception stack trace ---
1>C:\Users\elias\.nuget\packages\stride.core.assets.compilerapp\4.2.0.2188\buildTransitive\Stride.Core.Assets.CompilerApp.targets(222,5): error MSB3073: The command ""C:\Users\elias\.nuget\packages\stride.core.assets.compilerapp\4.2.0.2188\buildTransitive\..\lib\net8.0\Stride.Core.Assets.CompilerApp.dll" --pack --package-file="C:\Users\elias\source\repos\vvvv\VL.StandardLibs\VL.Stride.DefaultAssets\VL.Stride.DefaultAssets.csproj" --build-path="C:\Users\elias\source\repos\vvvv\VL.StandardLibs\VL.Stride.DefaultAssets\obj\stride\pack"" exited with code -532462766.
1>Done building project "VL.Stride.DefaultAssets.csproj" -- FAILED.

I suspect this was introduced with #2279 - while the StrideCompileAsset target uses dotnet ...Stride.Core.Assets.CompilerApp.dll the _StridePrepareAssetsForPack does not and crashes @Jklawreszuk

VaclavElias commented 2 months ago

I have the same issue, creating the package with the Stride.CommunityToolkit.Windows. However, the PR from @Jklawreszuk fixed the issue. I tested it with the most recent Stride commits.

@Eideren, when could we release new update for Stride as I won't be able to release the new version of the Stride.CommunityToolkit till this is deployed.

Eideren commented 2 months ago

@VaclavElias started the process, I'll ping you on discord once that's done