Will using C# attributes to optimize code submissions be accepted?

[Arc-huangjingtong]

Question and/or Comment

Will using C# attributes to optimize code submissions be accepted?

like

  if (fun == null)
  {
      fun.Invoke();
  }

be

fun?.Invoke();

[Eideren]

Not exactly sure I understand the question.

I'm guessing you meant;

if (fun != null)
{
    fun.Invoke();
}

For the first snippet.

If this question is about whether we would accept PRs which only contain code style changes, like you've shown above, not really ... we would rather your PR introduce at least a new feature, improve performance or fix a bug, if that's the case you may introduce change in style if they don't go against the style of the rest of the code base.

Reviewing style changes is very time consuming and if the PR doesn't do anything besides that it's often not worth the effort.

Let me know if I misinterpreted the question !

[Arc-huangjingtong]

Sorry，my english is not good ，but the word ‘like’ is ‘as sth be sth’ ， In short，I understand your mean。 if i use Span replace old code to reduce GC,Is that okay? or use other High level C# Feature to improve Performance or ReFactory Code to reduce code line num?Is that okay?

[Eideren]

if i use Span replace old code to reduce GC,Is that okay? or use other High level C# Feature to improve Performance

Yep, very much welcome

ReFactory Code to reduce code line num?Is that okay?

Just reducing the amount of lines, not really, but if you reduce the amount of lines while fixing a bug or while improving performance, yes.

[Arc-huangjingtong]

Thank You!

[NicusorN5]

Condider closing this thread @Arc-huangjingtong ?

[Ethereal77]

I didn't notice this was an issue. Why are there issues labeled as question if we have the Discussions tab in GitHub?

[Arc-huangjingtong]

[Ethereal77]

Well, then we should remove that and point users towards Discussions for questions and comments.

[VaclavElias]

Probably it was there historically. We can easily convert any issue to a discussion. Also, I can change that button to behave like the below, just links, so it could be just a link to Discussion.