stride3d / stride

Stride (formerly Xenko), a free and open-source cross-platform C# game engine.

https://stride3d.net

MIT License

6.65k stars 957 forks source link

perf: Refactor geometric primitive.cylinder to avoid GC #2369

Closed Arc-huangjingtong closed 4 months ago

Arc-huangjingtong commented 5 months ago

PR Details

Related Issue

Types of changes

[x] Docs change / refactoring / dependency upgrade
[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist

[ ] My change requires a change to the documentation.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.
[x] I have built and run the editor to try this change out.

Arc-huangjingtong commented 5 months ago

Test Success

Eideren commented 4 months ago

Thanks !

Arc-huangjingtong commented 4 months ago

You're welcome. I'm happy to help

Kryptos-FR commented 4 months ago

Note for later: I see a lot of code-style change that don't conform to the rest of the code base and will likely be changed again the next time the file is touched. Please refrain form using your "preferred code style" and stick to what is currently present.

For instance, we never align statements by adding additional spaces before the = sign.

Arc-huangjingtong commented 4 months ago

Note for later: I see a lot of code-style change that don't conform to the rest of the code base and will likely be changed again the next time the file is touched. Please refrain form using your "preferred code style" and stick to what is currently present.

For instance, we never align statements by adding additional spaces before the = sign.

Yes， I will remember