search

stride3d / stride

Stride (formerly Xenko), a free and open-source cross-platform C# game engine.
https://stride3d.net
MIT License
6.51k stars 942 forks source link

[Launcher] Check for disabledPackageSources (in NuGet.config) #287

Open SeleDreams opened 5 years ago

SeleDreams commented 5 years ago

Release Type: Official Release

Version: Xenko Launcher 3.0.1

Platform(s): Windows

Describe the bug Because Xenko Launcher doesn't check for disablePackageSources in NuGet.conf, if the xenko nuget packages are disabled, the xenko launcher will think it's offline and won't be able to connect to the internet to download the xenko builds from the internet

To Reproduce Steps to reproduce the behavior:

  1. open NuGet.config in %APPDATA%\NuGet\NuGet.config
  2. add these lines in configuration 
    <disabledPackageSources>
<add key="Xenko" value="true" />
<add key="Xenko Dev" value="true" />
</disabledPackageSources>
  3. The Xenko launcher cannot connect and download xenko builds

Expected behavior The launcher should check if the xenko package are disabled and automatically enable them, or ask the user the authorization to enable them

Screenshots unknown

Eideren commented 4 years ago

Isn't this expected behavior though ? If users explicitly disable nugget sources they probably don't want xenko/stride to attempt fetching them ? I'll mark this one as enhancement instead, seeing as we could extend the window to mention why it failed.

Kryptos-FR commented 4 years ago

@Eideren Yes I would also expect that the Launcher doesn't find them if the sources are disabled.

Not sure if the API let's us find out about disabled packages. If so, displaying a more explicit error message could be an option.