search

stridera / twitter-client

Assignment for the Codepath Class
0 stars 0 forks source link

[Android Bootcamp] Week 3 Complete #1

Open stridera opened 9 years ago

stridera commented 9 years ago

Had some issues trying to get clicks from populated listview items down to the listview onitemclicked listener. Still need to work on that. Still want to do some minor visual tweaking as well. Want to add more animations to make the twitter bird flip when the tweet is sent and have some clouds float by on the login screen. Having fun though.

Note: Although the video shows elements off the right side of the screen, it's not like that on the device. I'll have to figure out why it's cutting part of it off.

/cc @codepathreview @codepath

codepathreview commented 9 years ago

:+1: Excellent work again. Great to see you put in the effort to turn in a polished assignment.. A few notes after checking out the code:

Here's a detailed Project 3 Feedback Guide here which covers the most common issues with this submitted project. Read through the feedback guide point-by-point to determine how you could improve your submission.

Let us know if you have any other thoughts or questions about this assignment. Hopefully by now you feel pretty comfortable with all the major pieces to basic Android apps (Views, Controllers, ActionBar, Navigation, Models, Authentication, API Communication, Persistence, et al) and see how they all fit together. We are close now to a turning point in the course where you should be hitting a "critical mass" towards your knowledge of Android.

stridera commented 9 years ago

Thanks. :) I did add retweet and favorite. Will add follow soon when I add profile screens.

On Wed, May 27, 2015, 6:58 AM CodePath Reviewers notifications@github.com wrote:

[image: :+1:] Excellent work again. Great to see you put in the effort to turn in a polished assignment.. A few notes after checking out the code:

  • Good to see you were able to format the timestamp cleanly (consider externalizing to utils class)
  • Nice to see you used the SwipeRefreshLayout for easy timeline refreshes
  • Good to see you refreshed the timeline after composing a new tweet
  • Special mention for all the additional stories that you completed yourself (adding images to tweets is great but your custom bird progressbar is quite cool. Nice to see you're learning animations. We will be covering the same in future weeks).
  • Good to see you added ActiveAndroid annotations to the models for offline usage
  • Nice touch with the character count being displayed while the user composes a tweet.
  • Consider implementing retweet, favorite and follow functionality on timeline.

Here's a detailed Project 3 Feedback Guide here http://courses.codepath.com/snippets/intro_to_android/project_3_feedback which covers the most common issues with this submitted project. Read through the feedback guide point-by-point to determine how you could improve your submission.

Let us know if you have any other thoughts or questions about this assignment. Hopefully by now you feel pretty comfortable with all the major pieces to basic Android apps (Views, Controllers, ActionBar, Navigation, Models, Authentication, API Communication, Persistence, et al) and see how they all fit together. We are close now to a turning point in the course where you should be hitting a "critical mass" towards your knowledge of Android.

— Reply to this email directly or view it on GitHub https://github.com/stridera/twitter-client/issues/1#issuecomment-105921692 .