search

striezel / echarts-node-export-server

Node.js server for offline export of ECharts graphs
GNU General Public License v3.0
23 stars 11 forks source link

Alpha 1 #9

Closed miha42-github closed 1 year ago

miha42-github commented 1 year ago

Updated svc_ctl and fixed nginx

striezel commented 1 year ago

@miha42-github For what it's worth, I'd like to point out that a file in this pull request contains data about a private key. Since this data is now public, the key is compromised. You should probably consider revoking the certificate to avoid that a malicious actor can use it, and issue a new certificate, using a new private key. The new private key should then NOT be committed to any public repository.

miha42-github commented 1 year ago

Yes this was a mistaken commit. I'll be using git secrets to not store these kinds of data in public view.

miha42-github commented 1 year ago

Thank you for calling that out. I honestly appreciate it.

striezel commented 1 year ago

You're welcome. :)