strimzi / kafka-access-operator

Operator for sharing access to Strimzi clusters across namespaces
Apache License 2.0
17 stars 15 forks source link

Add Dockerfile and make and Azure steps to build it #6

Closed katheris closed 2 years ago

katheris commented 2 years ago

This PR does not include the steps to tag and push the docker image. Those will be added with the deployment files in a followup PR.

This PR only builds the amd64 architecture.

katheris commented 2 years ago

@scholzj that's a good point, I'll update it. At the moment the azure builds are configured to build the Java project and image but not try to push images anywhere, but they don't seem to run when a PR is raised. Does this need to be enabled from the repo settings?

scholzj commented 2 years ago

@katheris You have a wrong path there: templates/jobs/build/build_container.yaml instead of templates/jobs/build_container.yaml?

The build is triggered, but it failes because of path: https://dev.azure.com/cncf/strimzi/_build/results?buildId=114135&view=results

katheris commented 2 years ago

@scholzj ah ok, I'll sort that. How do I get from the PR to the azure build? I was expecting it to come up under the checks

katheris commented 2 years ago

@scholzj the Azure build is passing now

scholzj commented 2 years ago

How do I get from the PR to the azure build? I was expecting it to come up under the checks

When you have misconfiguration in the build like this, it does nto even start the build, so it does not report the error on the PR. You have to browse the builds to find it.