search

strimzi / kafka-kubernetes-config-provider

Kubernetes Configuration Provider for Apache Kafka®
Apache License 2.0
25 stars 12 forks source link

Add direct OkHttpClientFactory usage (#12) #13

Closed jchipmunk closed 2 years ago

jchipmunk commented 2 years ago

This PR adds direct OkHttpClientFactory usage. This solves the issue #12 with loading the HttpClient implementation when kafka-kubernetes-config-provider is deployed in the directory specified in the plugin.path property.

Signed-off-by: jchipmunk andrey.pustovetov@gmail.com

scholzj commented 2 years ago

@jchipmunk Can you please fix the DCO signoff? We cannot merge it without it.

jchipmunk commented 2 years ago

@jchipmunk Can you please fix the DCO signoff? We cannot merge it without it.

Thanks for the review. I have fixed the DCO signoff, the PR can be merged.

scholzj commented 2 years ago

@strimzi/maintainers Can we get a second review please?

scholzj commented 2 years ago

Thanks for the PR.